Issue 110254 - Implement "Security" tab page for "File/Properties"
Summary: Implement "Security" tab page for "File/Properties"
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m73
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: b.osi.ooo
QA Contact: issues@sw
URL: http://specs.openoffice.org/appwide/s...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 11:06 UTC by thomas.lange
Modified: 2013-08-07 14:44 UTC (History)
3 users (show)

See Also:
Issue Type: FEATURE
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.lange 2010-03-19 11:06:33 UTC 
The dialog "File/Properties" should get a new tab page "Security" (see spec).

Note: This includes that the tab page "Tools/Options - StarOffice - Security"
gets changed as well since the last controls from that get moved to the new tab
page.
Comment 1 thomas.lange 2010-03-19 11:07:19 UTC 
.
Comment 2 thomas.lange 2010-03-19 11:07:53 UTC 
Fixed in CWS tl79.

Files changed:

M cui/source/options/optinet2.cxx
M cui/source/options/optinet2.hrc
M cui/source/options/optinet2.hxx
M cui/source/options/optinet2.src

M sc/source/ui/docshell/docsh4.cxx

M sfx2/inc/sfx2/sfx.hrc
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/dinfdlg.src
M sfx2/source/dialog/makefile.mk
M sfx2/source/inc/helpid.hrc

A svtools/inc/svtools/xwindowitem.hxx
A svtools/source/misc/xwindowitem.cxx
M svtools/source/misc/makefile.mk

M svx/inc/svx/svxids.hrc

M sw/source/ui/uiview/view2.cxx

A sfx2/inc/sfx2/securitypage.hxx
A sfx2/source/dialog/securitypage.cxx
A sfx2/source/dialog/securitypage.hrc
A sfx2/source/dialog/securitypage.src
Comment 3 thomas.lange 2010-05-04 10:14:35 UTC 
.
Comment 4 thomas.lange 2010-06-10 12:18:47 UTC 
Note: currently the password edit fields in the tab-page are without function.
This can be fixed once CWS tl78 AND CWS tl79 are both integrated into the master.
(See follow-up issue 112277.)
Comment 5 thomas.lange 2010-06-11 08:45:12 UTC 
tl->tbo: Can you verify this one?
Comment 6 b.osi.ooo 2010-06-14 15:51:14 UTC 
There is a longname missing for the tabpage, the helpid is 33079, please assign
a name to it.
Looks like it should be HID_SECURITYTAB
Comment 7 b.osi.ooo 2010-06-14 15:54:39 UTC 
Also the text starting with 'Note:' is different to the one from the spec
screenshot? Which one should be the reference?
Comment 8 thomas.lange 2010-06-15 10:16:18 UTC 
TL->TBO: The spec needs to be changed, it does not yet show the text FL provided
in his latest mail.
Comment 9 thomas.lange 2010-06-15 11:03:12 UTC 
Linux OOO build ready. Windows still building.
Comment 10 b.osi.ooo 2010-06-15 15:29:09 UTC 
removed controls from options in testautomation hid.lst warnings fixed by
removing from:
global/win/etab_p_s.win
>  86 RecommendToOpenDocumentReadOnly
cui:CheckBox:RID_SVXPAGE_INET_SECURITY:CB_SEC_RECOMMREADONLY
>  87 RecordChanges cui:CheckBox:RID_SVXPAGE_INET_SECURITY:CB_SEC_RECORDCHANGES
>  88 Protect cui:PushButton:RID_SVXPAGE_INET_SECURITY:PB_SEC_PROTRECORDS
-> Declared new tab page in global/win/etab_p_s.win
*TabSecurityProperties HID_DOCINFOSECURITY
EnterPasswordToOpen HID_SECURITYTAB_PASSWORD_TO_OPEN
ReEnterPasswordToOpen HID_SECURITYTAB_CONFIRM_PASSWORD_TO_OPEN
EnterPasswordToModify HID_SECURITYTAB_PASSWORD_TO_MODIFY
ReEnterPasswordToModify HID_SECURITYTAB_CONFIRM_PASSWORD_TO_MODIFY
RecommendToOpenDocumentReadOnly HID_SECURITYTAB_OPEN_FILE_READONLY
RecordChanges HID_SECURITYTAB_RECORD_CHANGES
Protect HID_SECURITYTAB_PROTECTION

changed testfiles
framework/optional/includes/options_ooo_general.inc
framework/optional/includes/options_ooo_security.inc

comitted, pushed and verified
Comment 11 b.osi.ooo 2010-06-16 10:43:51 UTC 
changed to feature
Comment 12 b.osi.ooo 2010-09-07 12:55:02 UTC 
.