Issue 111034 - check configurations before removing their listeners in SwModule
Summary: check configurations before removing their listeners in SwModule
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m76
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: mikhail.voytenko
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 40233
  Show dependency tree
 
Reported: 2010-04-21 10:10 UTC by zhangxiaofei.ooo
Modified: 2017-05-20 11:41 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
A patch to fix the issue (1.31 KB, text/plain)
2010-04-21 10:18 UTC, zhangxiaofei.ooo
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description zhangxiaofei.ooo 2010-04-21 10:10:46 UTC
SwModule::Notify() removes the listeners of configurations before checking the 
configurations themselves, this could lead to potential crashes. Change it 
referring to the implementation of ScModule::DeleteCfg()
Comment 1 zhangxiaofei.ooo 2010-04-21 10:17:16 UTC
With the patch of i40233 applied, the issue described above will lead to crash 
with the following steps performed:
* Start office.
* "File" - "Templates" - "Organize" from menu.
* Select a template to set as default.
* Quit office and crash.
Comment 2 zhangxiaofei.ooo 2010-04-21 10:18:16 UTC
Created attachment 69019 [details]
A patch to fix the issue
Comment 3 zhangxiaofei.ooo 2010-04-21 10:20:02 UTC
The patch is better integrated with the one for i40233
Comment 4 mikhail.voytenko 2010-05-06 14:03:59 UTC
Thank you for the patch. I will integrate it in one of the next framework cws's.
Comment 5 mikhail.voytenko 2010-05-26 14:55:48 UTC
Integrated in fwk139.
Comment 6 carsten.driesner 2010-06-10 09:36:15 UTC
cd: Verified on CWS fwk139.