Issue 111035 - [xmloff,forms] ODF 1.2 export writes invalid xlink:href
Summary: [xmloff,forms] ODF 1.2 export writes invalid xlink:href
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m73
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: Frank Schönheit
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-21 10:17 UTC by mst.ooo
Modified: 2017-05-20 09:30 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch (926 bytes, patch)
2010-04-21 14:09 UTC, Frank Schönheit
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description mst.ooo 2010-04-21 10:17:51 UTC
exporting a form:form element to ODF 1.2 yields an invalid file:

/tmp/p_.odp/content.xml[85,193]:Error:element "form:form" is missing "type"
attribute

<form:form form:name="Standard" form:apply-filter="true"
form:command-type="table"
form:control-implementation="ooo:com.sun.star.form.component.Form"
office:target-frame="" xlink:href="">

ODF 1.2 cd04 schema:

<define name="form-form-attlist" combine="interleave">
    <optional>
		<attribute name="xlink:type">
			<value>simple</value>
		</attribute>
        <attribute name="xlink:href">
            <ref name="anyURI"/>
        </attribute>
        <optional>
            <attribute name="xlink:actuate">
                <value>onRequest</value>
            </attribute>
        </optional>
    </optional>
</define>

this seems to have changed from ODF 1.1, where the xlink:type was optional:

<define name="form-form-attlist" combine="interleave">
    <optional>
        <attribute name="xlink:href">
            <ref name="anyURI"/>
        </attribute>
        <optional>
            <attribute name="xlink:type" a:defaultValue="simple">
                <value>simple</value>
            </attribute>
        </optional>
        <optional>
            <attribute name="xlink:actuate" a:defaultValue="onRequest">
                <value>onRequest</value>
            </attribute>
        </optional>
    </optional>
</define>

[if you prefer you can attach a patch and i'll commit it on sw33bf03]
Comment 1 mst.ooo 2010-04-21 10:18:48 UTC
oops, i guess this is P2, right?
Comment 2 Frank Schönheit 2010-04-21 14:09:32 UTC
Created attachment 69027 [details]
patch
Comment 3 Frank Schönheit 2010-04-21 14:10:06 UTC
thanks for this offering, patch attached.
Comment 4 mst.ooo 2010-04-21 14:46:32 UTC
fixed in cws sw33bf03
http://hg.services.openoffice.org/hg/cws/sw33bf03/rev/ee077e4f664c
Comment 5 eric.savary 2010-04-29 14:33:00 UTC
@FS: please verify.
Comment 6 Frank Schönheit 2010-04-30 10:53:59 UTC
so I am verifying my own patch now? Hmm ....
Comment 7 niklas.nebel 2010-09-07 08:54:50 UTC
*** Issue 114359 has been marked as a duplicate of this issue. ***