Apache OpenOffice (AOO) Bugzilla – Issue 112421
vcl: Tweak DefaultDisplay for xinerama/xrandr case ?
Last modified: 2011-09-01 21:21:47 UTC
X11SalSystem::GetDefaultDisplayNumber is the backend which returns the "DefaultDisplay" for e.g. the monitor for the presenter screen to show on in multihead mode. If we're in "classic" multi-screen X configuration it'll return the DefaultScreen number, but it also returns that number for the Xinerama-style mode of a single "Screen" but multiple frame-buffers/monitors. i.e. in that configuration it's always Monitor 0 for us. gtk has a (fairly new) gdk_screen_get_primary_monitor api where "The primary monitor is considered the monitor where the 'main desktop' lives.". This is the monitor that typically has the gnome-panel on it, and the default monitor on which apps open up, which is an apparent good fit for what our "DefaultDisplay" is targeted to do. In the attached patch if that's not available then try a gdk_screen_get_primary_monitor-alike fallback of looking at the monitor names and attempt to prefer laptop internal monitors as the "DefaultDisplay"/"Primary Monitor" over external ones. The general goal being that out-of-the-box the presenter screen defaults to starting on a laptop's internal screen and the presentation itself on the external screen. At the moment the presenter screen starts on the first xinerama/xrandr entry in the list which might or might not be the laptop monitor. Having the presenter screen start on the external monitor, and the presentation itself on the laptop is an annoying whiny complaint I hear regularly.
Created attachment 70014 [details] How about this
That makes sense to me. How does the "LVDS" name come to pass ?
I'm told that it's low voltage differential signalling http://www.linktionary.com/l/lvds.html *shrug*
But that means that this string compare is rather arbitrary; on how many desktops is that going to work ? Anyway the main point of this is gdk_screen_get_primary_monitor which seems like a good idea. Perhaps a good candidate for your gtk3 CWS ?
My understanding is that all laptop monitors get called LVDSx. But yes, gdk_screen_get_primary_monitor is the main thrust of the affair. Sure, I can put this in cws gtk3. That'll end up being a 3.4 thing in that case though. gtk3 stuff seems works fine, but makefile hackery makes me want to put it ontop of new build thingy when available.
meant to change ownership to myself
done in gtk3
reopen to move
cmc->pl: I'll have this over for you guys to consider if you want to take it.
thanks
adapted and committed in CWS vcl116.
verified in CWS vcl116
integrated in DEV300_m92, closing
Just a note ... For LibreOffice 3.3 there is a note concerning this issue: REVERT "make Presenter Screen default to the laptop, not projector" No idea if it applies to the OO code but some review may be good.
Actually.. the LO comment was from before Oct-11 2010 so we can assume this was fixed properly in OO.