Apache OpenOffice (AOO) Bugzilla – Issue 112602
package: use rtl::Static to wrap globals
Last modified: 2017-05-20 09:30:34 UTC
The attached patch... a) Replaces the hand-rolled "static pointer check + guard + static object and assign to pointer" patterns with the rtl::Static template implementation of the same pattern. No real change, just slightly prettier I guess. b) Replaces the global aImplementationId objects with rtl::Static equivalents in order to give a deterministic order of construction and destruction which ensures that uno::Sequences don't outlive the cppu infrastructure which is required for them to work correctly. Currently the cppu stuff deliberately leaks, so this isn't noticeable at the moment. (as an aside, the ctor argument to ::cppu::OImplementationId is passed down to rtl_createUuid as bUseEthernetAddress and is ignored these days, so I've made the change to omit it here as well, which makes things simpler)
Created attachment 70148 [details] like so
Created attachment 70204 [details] better effort
Thank you for the patch, I will integrate it in one of the next framework cws's.
Integrated in cws fwk149
Development issue, setting to verified by myself.