Issue 113334 - wizards: Import wizard hardcoded "StarOffice" string
Summary: wizards: Import wizard hardcoded "StarOffice" string
Status: CONFIRMED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOO330m1
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.1
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-21 13:17 UTC by santiago.bosio
Modified: 2013-01-29 21:41 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description santiago.bosio 2010-07-21 13:17:40 UTC
On import wizard's first screen all strings that refers to the product have a
%PRODUCTNAME placeholder, but one that is hardcoded in Basic code in
'wizards/source/importwizard/Language.xba' at line 84.

IMHO it should be replaced by %PRODUCTNAME.

Best regards,

Santiago
Comment 1 Olaf Felka 2010-07-21 13:27:13 UTC
@ is: Are you the owner of this issue? Is there a chance/need to get for 3.3?
There is a few more StarOffice in this file.
Comment 2 ingo.schmidt-rosbiegal 2010-07-21 16:52:27 UTC
is -> va: This task is for you. Is it required for 3.3 ?
Comment 3 weko 2010-07-21 17:04:34 UTC
@ih: Could you please check the effort for this task?
Comment 4 nospam 2010-07-22 12:32:05 UTC
In this wizard the string "StarOffice" is used for the OLD document formats (e.g. *.sd*) and for them it is ok 
- they are NOT Oracle Open Office documents. 

So, I think it is correct to use StarOffice there - really NO need to change it.
Comment 5 santiago.bosio 2010-07-26 14:24:13 UTC
Then this string should be changed, IMHO:

importwi.src#sWelcometextLabel1.string.text
"This wizard converts documents in %PRODUCTNAME format and Microsoft Office
documents to the new OpenDocument format."

Because it uses %PRODUCTNAME and gets replaced by "OpenOffice.org" what makes a
nonsense. It should be something like:

"This wizard converts documents from StarOffice/OpenOffice.org old binary
formats and Microsoft Office documents to the new Open Document Format."

And that "StarOffice" line for "StarOffice / OpenOffice.org old binary formats"

OpenOffice.org should be included besides StarOffice because it used that format
up to the version 1.5.

Best regards,

Santiago
Comment 6 santiago.bosio 2010-07-26 14:28:34 UTC
Also, all the similar strings to:

importwi.src#sSumSOTextDocuments.string.text
"All %PRODUCTNAME text documents contained in the following directory will be
imported:"

should be re-phrased as:
"All StarOffice / OpenOffice.org old binary text documents contained in the
following directory will be imported:"

Best regards,

Santiago

Comment 7 nospam 2010-07-26 14:34:06 UTC
@gw: what do you think about this string? Should we change it?



Comment 8 Olaf Felka 2010-07-26 14:52:37 UTC
I think that the old binary formats (.sd*) are StarOffice only formats. Just
like .doc is a Microsoft format. If you save a file in 
So "All StarOffice / OpenOffice.org old binary..." is simply wrong.
Comment 9 mdxonefour 2010-07-26 15:00:32 UTC
@of: Confirmed. It's the "StarOffice" format.
@ih: In my point of view it's correct to leave the string as it is right now.
Comment 10 santiago.bosio 2010-07-26 15:26:57 UTC
@md: I understand your point of view, and it is OK, the .sd* formats were
defined by StarOffice, but they were also used by OpenOffice.org up to the
version 1.5. From the perspective of some users, perhaps mistakenly, it was the
OpenOffice.org 1.x format.

Besides that the other strings are not ok in that they use the %PRODUCTNAME
variable that gets replaced by "OpenOffice.org", or "Oracle Open Office",
depending on the builder. Perhaps, when it was replaced by "StarOffice" (the
commercial version from Sun) before Oracle's acquisition, these strings had sense.

If you're going to maintain the "StarOffice" string, then the other strings
should be changed, and %PRODUCTNAME replaced by "StarOffice" also. If you don't,
the other strings don't have any sense, see:

"This wizard converts documents in OpenOffice.org format and Microsoft Office
documents to the new OpenDocument format."

or 

"This wizard converts documents in Oracle Open Office format and Microsoft
Office documents to the new OpenDocument format."

Best regards,

Santiago
Comment 11 nospam 2010-07-26 15:35:33 UTC
.
Comment 12 nospam 2010-09-29 13:28:27 UTC
ih->gw:please decide what to do here