Issue 114135 - svx/cui/etc: default "document" colour
Summary: svx/cui/etc: default "document" colour
Status: ACCEPTED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: DEV300m86
Hardware: Unknown All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 97765
  Show dependency tree
 
Reported: 2010-08-26 21:14 UTC by caolanm
Modified: 2013-03-11 15:03 UTC (History)
5 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
like so (16.11 KB, patch)
2010-08-26 21:15 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2010-08-26 21:14:15 UTC 
I see that we take the default document background colour from the vcl
StyleSettings "GetWindowColor". I wonder if that's really a good idea ? Should
the default Window colour really be the default Document colour, especially
given the very dark themes such as DarkLooks etc which are popular (for some
reason I don't understand) which give a brown page by default.

Maybe it would be a better idea to separate the concepts a bit from each-other,
and default Document backgrounds to white regardless of the theme, and leave the
"WindowColor" concept solely for widgets.

Attached is a patch to default the Document background to white and the Document
Font foreground to black. I've gone through a pile of dialogs and synced up
anything that draws a page preview to follow the same logic of tracking those
settings for their background and foreground.

Should we do this ?
Comment 1 caolanm 2010-08-26 21:15:01 UTC 
Created attachment 71418 [details]
like so
Comment 2 carsten.driesner 2010-09-07 16:55:23 UTC 
cd->cmc: Thanks for the patch. I want to ask UX team to change the algorithm for
the default document color.

cd->fl: What's your opinion regarding this patch?
Comment 3 carsten.driesner 2010-10-22 09:49:34 UTC 
cd: Set es and hjs on CC.

cd: Outcome from the discussion with UX. We want to apply this patch to
temporary CWS to test this patch, especially regarding high-contrast themes/modes.

cd: Therefore I remove this patch from CWS fwk149.
Comment 4 Rob Weir 2013-03-11 15:03:41 UTC 
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob