Issue 114601 - officecfg: util/makefile.mk file tries to remove files from /bin directory
Summary: officecfg: util/makefile.mk file tries to remove files from /bin directory
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO330m7
Hardware: PC (x86_64) Linux, all
: P3 Trivial (vote)
Target Milestone: 3.4.0
Assignee: Stephan Bergmann
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-19 19:09 UTC by gokcen
Modified: 2011-02-28 12:43 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch file fixing the issue (631 bytes, patch)
2010-09-19 19:10 UTC, gokcen 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description gokcen 2010-09-19 19:09:07 UTC 
During the build of ooo-build-3.2.98.1 (ooo330m7), I've seen build output:

rm -f ../unxlngx6.pro/bin/registry_en-US.zip 
../unxlngx6.pro/bin/registry_de.zip ../unxlngx6.pro/bin/registry_es.zip 
../unxlngx6.pro/bin/registry_fr.zip ../unxlngx6.pro/bin/registry_hu.zip 
../unxlngx6.pro/bin/registry_it.zip ../unxlngx6.pro/bin/registry_nl.zip 
../unxlngx6.pro/bin/registry_pt-BR.zip ../unxlngx6.pro/bin/registry_sv.zip 
../unxlngx6.pro/bin/registry_tr.zip     

rm -f /bin/registry_en-US.zip /bin/registry_de.zip /bin/registry_es.zip 
/bin/registry_fr.zip /bin/registry_hu.zip /bin/registry_it.zip 
/bin/registry_nl.zip /bin/registry_pt-BR.zip /bin/registry_sv.zip 
/bin/registry_tr.zip


First line is OK but in second line OpenOffice tries to delete some zip files
from /bin directory, which is unusual. There is a typo in makefile.mk file and
the attached patch fixes the error.
Comment 1 gokcen 2010-09-19 19:10:16 UTC 
Created attachment 71760 [details]
Patch file fixing the issue
Comment 2 Stephan Bergmann 2010-09-20 13:15:31 UTC 
Thanks for the patch.  It appears officecfg/util/makefile.mk needs some clean
up, anyway.  (If $(COMMON_OUTDIR)$/bin$/registry_{$(alllangiso)}.zip were
actually used, rm'ing it would introduce a race for concurrent builds using
common output trees.)

@hjs:  That makefile can be reduced to the following, dropping the ..._delzip
target, right?

ALLTAR: $(MISC)/registry_{$(alllangiso)}.zip
$(MISC)/registry_{$(alllangiso)}.zip:
  - $(RM) $@
  cd $(MISC)/... && zip ...
  $(PERL) ...
Comment 3 hjs 2010-09-21 17:23:06 UTC 
that won't work for incremental builds as the .zip file would never be updated.
the current implementation builds the .zip from scratch every time, probably it
doesn't know about it's dependencies.

either add .PHONY 

...
$(MISC)/registry_{$(alllangiso)}.zip .PHONY:
...

or consider to use the generic ZIP target (e.g. svx/uiconfig/layout/layout.mk)
which creates dependencies on the archived files
Comment 4 Stephan Bergmann 2011-01-10 13:12:56 UTC 
In the meantime, CWS gnumake2 removed the common output tree feature, so the
line containing the COMMON_OUTPUT typo can simply be completely removed.  Fixed
as <http://hg.services.openoffice.org/cws/sb139/rev/32ab4f4b0d54>.
Comment 5 Stephan Bergmann 2011-01-31 14:54:24 UTC 
.