Issue 115437 - Smart tags: recognized words aren't underlined
Summary: Smart tags: recognized words aren't underlined
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: OOo 3.3 RC3
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks: 111112
  Show dependency tree
 
Reported: 2010-11-06 10:49 UTC by nawey
Modified: 2013-08-07 14:44 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to solve the problem (631 bytes, text/plain)
2010-11-09 15:00 UTC, Armin Le Grand 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description nawey 2010-11-06 10:49:20 UTC 
Recognized words are not underlined violet in OpenOffice.org Writer. Install
either of these extensions:
http://extensions.services.openoffice.org/project/LatitudeAndLongitude (paste
32.30642° N 122.61458° W in Writer)
http://extensions.services.openoffice.org/project/stcalculator (paste 1+2 in Writer)
Then you can Ctrl+Click the tag, but it is not underlined.

(Ubuntu 10.04 + JRE6u18)
Comment 1 michael.ruess 2010-11-08 16:26:39 UTC 
The "smart tags" functionality itself is not broken - the dotted line "just"
won't be painted; you will still be able to open the Smart tags context menu
properly on desired expressions.

MRU->OD: please post your findings about the facts here and then hand over to
AW. Thanks!
Comment 2 Oliver-Rainer Wittmann 2010-11-09 09:00:10 UTC 
od->aw:
As already discussed:
The root cause is in method <impPaintLineGeometryWithEvtlExpand(..)>
(vcl/source/gdi/outdev.cxx) - it seems that applyLineDashing(..) does not work
as expected. The dashed line with the setup distance = 40, dashlen = 1 and
dashcount = 1 in Twip is not painted. It should be painted a dashed line which
dash are on pixel wide.
The paint of this dashed line is triggered in method
<lcl_DrawLineForWrongListData(..)> (sw/source/core/txtnode/fntcache.cxx)

From my point of view this defect could be something for OOo 3.3
Comment 3 Armin Le Grand 2010-11-09 14:57:50 UTC 
AW: Identified. Inside void OutputDevice::DrawLine( const Point& rStartPt, const
Point& rEndPt, const LineInfo& rLineInfo ) in VCL the initialisation for the
LineColor Pen (ImplInitLineColor()) is missing when fat or dashed line is used.
This is missing since #i105655# DEV300/aw078. A simple and non-risky fix is
possible. I will add a patch for this.
Comment 4 Armin Le Grand 2010-11-09 15:00:01 UTC 
Created attachment 72915 [details]
Patch to solve the problem
Comment 5 vitriol 2010-11-10 14:07:39 UTC 
Add me to CC
Comment 6 mdxonefour 2010-11-10 14:08:35 UTC 
adjusting target to 3.3
Comment 7 Oliver-Rainer Wittmann 2010-11-10 14:39:00 UTC 
applied patch to cws sw33bf12 - change file:
/vcl/source/gdi/outdev.cxx, change set c25bcf0b738b

Note: not pushed to hg.services.openoffice.org/cws/sw33bf12 yet because of the
current outage
Comment 8 Oliver-Rainer Wittmann 2010-11-10 15:03:18 UTC 
od->mru: Checked in internal installation set of cws sw33bf12 - please verify.
Comment 9 michael.ruess 2010-11-11 11:39:51 UTC 
Verified in CWS sw33bf12.
Comment 10 michael.ruess 2010-11-16 16:38:36 UTC 
Checked in OOO330m15.