Apache OpenOffice (AOO) Bugzilla – Issue 115580
copy words from writer/calc to impress, font size changed.
Last modified: 2017-05-20 11:33:30 UTC
Can reproduce it in OOo3.3RC4 on WinXP. copy words from writer/calc to impress, some font size may get bigger. See attachments.
Created attachment 74800 [details] Writer source file
Created attachment 74801 [details] Calc source file
Created attachment 74802 [details] WriterToImpress:some characters become bigger
Created attachment 74803 [details] CalcToImpress:some characters become bigger
From Writer/Calc to Impress: Some characters become bigger, namely fontsize from '小四' to '小二'. Maybe it is related to issue 80898. http://www.openoffice.org/issues/show_bug.cgi?id=80898
OS: from Win XP to All
cjk
Assinged to jingdong after a short talk with him
I am familiar with the relevant code on copy&paste operation, as to this bug, I will try my best to fix it. this bug has also been assigned to me by Raphael.
to start it from 2011-10-08
Created attachment 76800 [details] Messy text appears when pasting from Writer To Impress. Messy text appears when pasting from Writer To Impress.
I found another problem on issue #115580 in AOOo3.4 WindowsXP: 1) copy&paste a text from Calc to impress 1. Creat a clac document; 2. Input text string in any cell of clac sheet; 3. Copy and paste this text into impress. actual result: font attribs have changed, e.g. font type, font size. expectated result: keep the same font attribs, besides text. 2) copy&paste a text from writer to impress 1. Creat a writer document; 2. Input a line of text string in writer doc; 3. Copy and paste this text into impress. actual result: 1. text string is messy, maybe due to an incorrect text encoding. 2. font attribs have changed, e.g. font type, font size. expectated result: keep the same text without garbled char and with correct font attribs.
I found another problem on issue #115580 in AOOo3.4 WindowsXP: 1) copy&paste a text from Calc to impress 1. Creat a clac document; 2. Input text string in any cell of clac sheet; 3. Copy and paste this text into impress. actual result: font attribs have changed, e.g. font type, font size. expectated result: keep the same font attribs, besides text. 2) copy&paste a text from writer to impress 1. Creat a writer document; 2. Input a line of text string in writer doc; 3. Copy and paste this text into impress. actual result: 1. text string is messy, maybe due to an incorrect text encoding. 2. font attribs have changed, e.g. font type, font size. Refer to the attachment: 76800. expectated result: keep the same text without garbled char and with correct font attribs.
Created attachment 77026 [details] To fix the part of this issue - pasting from sc to sd So far, I've just fixed a part of the issue:115580, pasting the text content from sc to sd, another part(pasting from sw to sd) have not finished yet, due to some problems of our company.
I have committed your change: svn commit -m "i115580: Fix pasting from sc to sd. Patch by JingDonChen." Sending editeng/source/editeng/impedit.hxx Sending editeng/source/editeng/impedit2.cxx Sending editeng/source/editeng/impedit4.cxx Sending editeng/source/editeng/impedit5.cxx Transmitting file data .... Committed revision 1203218. Thank you very much for your contribution!
(In reply to comment #17) > I have committed your change: > I undid this change for now: The patch is good but in general there is consensus that we should hold from fixing these type of bugs until we have the IP Review (critical for release) under control. (Well I also broke the build with another change so I preferred to revert now everything.) I do want to encourage you to finish this important bugfix so that we can commit a complete fix before 3.4 Release. Thanks!
Comment on attachment 77026 [details] To fix the part of this issue - pasting from sc to sd In this patch the func - AdjustParaAttribsByStyleSheet had better do a little change, as follow: if ( pNode->GetContentAttribs().HasItem( nWhich ) ) ==>should be changed to if ( pNode->GetContentAttribs().GetItems().GetItemState( nWhich, sal_False ) == SFX_ITEM_ON )
Created attachment 77048 [details] Updated patch I have updated your patch with the change you requested and I also reduced your comments: Once committed it will be evident in SVN who did the changes, where they start and where they end. Also please note that the indentation in the third chunk of editeng/source/editeng/impedit4.cxx is incorrect (I moved it back a little to be nearer to the "else"). Thanks for working on this.
Created attachment 77052 [details] To fix this issue completely, by JingDongChen from china, 2011-11-28. The patch(Bug115580_20111128.diff) completely fixed this issue, and it insteads of the past patch(Bug115580.diff). Is there anybody to test it ASAP? looking forward to the result of test! thanks!
Hello; Sorry for the delay but this is not an area where finding an expert is easy (I am certainly not one)! One question concerning the code in sw/source/ui/app/docshini.cxx Is it absolutely unavoidable to do all those language checks when creating a new document? I would think that those have to be done just the same every time you change the font so there's probably code already to do that elsewhere.
Created attachment 77219 [details] Updated patch - comment cleanups Many cleanups in form: There's no need to mention the date: for one thing the patch will likely be applied in a different day than when it was written, but also SVN registers the date. Likewise it's not necessary to tag where the changes start or end. There were some indentation issues too.
Comment on attachment 77048 [details] Updated patch This was only for the first part it's obsolete now.
Apparently there are no objections towards the approach used by Jing Dong and I see no reason to perpetuate this issue: Sending editeng/source/editeng/editdoc.cxx Sending editeng/source/editeng/editdoc.hxx Sending editeng/source/editeng/eertfpar.cxx Sending editeng/source/editeng/impedit.hxx Sending editeng/source/editeng/impedit2.cxx Sending editeng/source/editeng/impedit4.cxx Sending editeng/source/editeng/impedit5.cxx Sending sw/inc/docsh.hxx Sending sw/source/ui/app/docshini.cxx Sending sw/source/ui/dochdl/swdtflvr.cxx Transmitting file data .......... Committed revision 1291962. Thank you for your contribution and the patience to resolve this issue!
Created attachment 77251 [details] Debug Window in a non-product build Opening a new Draw or Impress document causes the following assertion several times: Error: SetText failed From File /mnt/build/openoffice/apache/trunk/main/editeng/source/outliner/outliner.cxx at Line 617 When the changes made for this issue are reverted, these assertions are gone.
Reopened. Those assertions are obviously triggered by the changes for this issue. You should investigate if they point to some error in the code introduced or not.
(In reply to comment #25) > Apparently there are no objections towards the approach used > by Jing Dong and I see no reason to perpetuate this issue: obviously this meant that nobody in the know of the affected code had the time to look deep into this patch. You should really stop committing patches by others as far as you do not have a deep knowledge of the subject. Committing code means verifying * the patch applies * the code builds * the code works * no regressions where introduced * and so on
Hmmm .. I spent some time cleaning the code, I have the patches running in my system, I had the code reviewed by someone else, and ... still shit happens, sorry. Except for build fixes I wont be committing any more patches until after the release anyways, this was the last pending issue for me.
The issue is only seen while debugging, it apparently had no real consequence on the working instance and that's why I didn't notice anything strange in my testing. For now I reverted the changes in Revision 1293507.
Reset assigne to the default "issues@openoffice.apache.org".