Issue 116355 - Wrong check for empty SYSBASE in solenv/gbuild/platform/macosx.mk
Summary: Wrong check for empty SYSBASE in solenv/gbuild/platform/macosx.mk
Status: CONFIRMED
Alias: None
Product: Build Tools
Classification: Code
Component: GNU make (show other issues)
Version: DEV300m96
Hardware: All Mac OS X, all
: P2 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 116476 (view as issue list)
Depends on:
Blocks:
 
Reported: 2011-02-24 14:07 UTC by hans_werner67
Modified: 2013-01-29 21:48 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description lohmaier 2011-01-08 00:02:41 UTC
solenv/gbuild/platform/macosx.mk checks for empty SYSBASE with

ifeq($(SYSBASE), "")

this is wrong, and results in the statement always evaluating to false, 
resulting in a -isysroot /MacOSX10.4u.sdk to be used, and the build fails 
horribly because no standard-headers can be found.

correct is:

ifeq ($(SYSBASE),)
gb_SDKDIR := /Developer/SDKs/MacOSX10.4u.sdk
else
gb_SDKDIR := $(SYSBASE)/MacOSX10.4u.sdk
endif

(see http://www.gnu.org/software/autoconf/manual/make/Conditional-Syntax.html - 
where at the explanation for ifdef it reads: "To test for an empty value, use 
ifeq ($(foo),).")
Comment 1 bjoern.michaelsen 2011-01-08 03:23:01 UTC
already fixed in cws ause129
http://hg.services.openoffice.org/cws/ause129/rev/bf9dbc609cb7

reassigning to hjs for adding it to the cws.
Comment 2 mst.ooo 2011-02-08 12:04:44 UTC
*** Issue 116476 has been marked as a duplicate of this issue. ***
Comment 3 Oliver-Rainer Wittmann 2012-06-13 12:31:36 UTC
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.