Apache OpenOffice (AOO) Bugzilla – Issue 118623
Update Rhino from 1.5R5 to 1.7R3
Last modified: 2017-05-20 09:32:04 UTC
Created attachment 77037 [details] Patch for Rhino1.7R3 itself. I made a patch to update from Rhino 1.5R5 to 1.7R3. This patch is made by re-constructing rhino1_5R5.patch for Rhino 1.7R3. rhino1_7R3.patch includes differences patched during to build Rhino, put it into rhino/. rhinoupdate1_7R3.patch gives differences about Makefile of the rhino module and the script provider for JavaScript. Remove rhino1_5R5.patch, rhino1_5R5-find_swing.patch and rhino1_5R5-updateToolTip.patch. Download rhino1_7R3.zip from: https://developer.mozilla.org/en/Rhino_downloads_archive and put it into ext_source as 99d94103662a8d0b571e247a77432ac5-rhino1_7R3.zip. rhino1_7R3.patch has LGPL header based on the original patch, rhino1_5R5.patch in the part of difference of OfficeScriptInfo.java. Rhino 1.7R3 has some files in its debugger mentioned at: https://developer.mozilla.org/en/Rhino/License .
Created attachment 77038 [details] Patch for Makefile and the script framework for JavaScript.
This patch needs additional task to update the part to download Rhino source package. And the package have to be uploaded into the repository. I am sorry I could not do it because I am not a commiter.
Hi; Three points: - FreeBSD uses this patch which will likely be relevant http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/lang/rhino/files/patch-xmlimplsrc%2Bbuild.xml?rev=1.1 - There is a new file under the LGPL in your first patch - We still cant carry rhino in our distribution, and downloading + patching is not acceptable either. If we cant use it as a prebuilt binary we will have to upstream the patches (difficult) or try Chrome V8.
@Pedro > - FreeBSD uses this patch which will likely be relevant Now AOO needs Java 5 or 6 and it has w3c dom. If it is there, rhino use it and xmlbeans is not needed. https://developer.mozilla.org/en/New_in_Rhino_1.7R1#section_3 > - There is a new file under the LGPL in your first patch I have mentioned about it in the comment. I have not noticed license header of most files are updated to AL2 until today. The license header is copyrighted to Oracle and maybe it is included in SGA. But I could not replace it myself. > - We still cant carry rhino in our distribution, and downloading + patching is not acceptable either. Oh, it seems I confused on it. > or try Chrome V8 I have tried to make V8-UNO bridge but I have met a problem on exceptions between V8 and UNO. And I also considered about to use V8 as macro engine. Python has some useful modules and easy to import to use with Python macros. But V8 does not have import feature except for the proposed by CommonJS modules. Java's components can not be used on V8 too. If V8 is introduced as a macro engine, it takes a position below the Basic.
According to IP clearance this issue has no feature. -> INVALID
(In reply to comment #3) > - We still cant carry rhino in our distribution, and downloading + patching > is not acceptable either. If we cant use it as a prebuilt binary we will have > to upstream the patches (difficult) or try Chrome V8. Per the discussion @dev I was wrong on this point: we can download and patch rhino binary. If this was the reason for setting it invalid then it can be reopened. I think The new file in the patch can be relicensed directly to avoid the trouble identifying it at a later time or we can wait until the SGA is completed. Thanks for looking at V8!
>Per the discussion @dev I was wrong on this point: we can download and patch rhino binary. If this was the reason for setting it invalid then it can be reopened. Thank you. I reopened.
(In reply to comment #4) > > or try Chrome V8 > I have tried to make V8-UNO bridge but I have met a problem on exceptions > between V8 and UNO. And I also considered about to use V8 as macro engine. > Python has some useful modules and easy to import to use with Python macros. > But V8 does not have import feature except for the proposed by CommonJS > modules. Java's components can not be used on V8 too. If V8 is introduced as a > macro engine, it takes a position below the Basic. I found a V8 Java bridge here: http://rbackhouse.blogspot.com/2011/03/using-google-v8-javascript-engine-in.html And the license looks good: https://github.com/rbackhouse/zazl
Checked in the changes. The last of the four commits (two were planned, the other two are due to differences between git and svn and my stupidity) is revision 1222621.
Thanks about commit the patch and about build system. Update status to Fixed.
getting rid of value "enhancement" for field "severity". For enhancement the field "issue type" shall be used.