Apache OpenOffice (AOO) Bugzilla – Issue 119403
AOO 3.4 - GridControl not refreshing after deleting rows
Last modified: 2017-05-20 09:32:10 UTC
Created attachment 77580 [details] CALC macro to display GridContol. Buttons to add / remove rows. I use Windows 7 and AOO 3.4. GridControl in user-dialog is not refreshing when rows are removed with BASIC-command "DeleteRow" within CALC-Macro. To check the problem see Calc-file with attached macro. Grid is only updated after minimizing und maximizing the Window on the desktop. With the same macro there is no repaint problem in Libre Office 3.5. Procedure to reproduce the bug on the attached document: - open the attached document and push button to show the dialog, => dialog having a grid control with two buttons is shown - push "AddRow" button five times, => 5 rows are added - push "RemoveRow" button three times, => the removed 3 rows are still displayed within grid.
.
Can reproduce in Aoo3.4.
The grid window filled by background color on 3.3 but current grid uses transparent background, so it should be invalidated with INVALIDATE_TRANSPARENT in TableControl_Impl::invalidateRowRange, svtools/source/table/tablecontrol_impl.cxx .
Created attachment 78209 [details] Proposed patch to invalidate for transparency background Described above.
reviewed, built and tested on trunk, patch applied trunk -> revision 1348750
Changed to VERIFIED. Verified on trunk r1350879.
Not fixed on branch, r1332941. So I reopened it.
It is not a release blocker. Do not need to commit to branch. So I changed to resolved again.
NOT FIXED with last developer build 1372282.
(In reply to comment #10) > NOT FIXED with last developer build 1372282. the patch applied only trunk, not for branch AOO34
(In reply to comment #11) > (In reply to comment #10) > > NOT FIXED with last developer build 1372282. > > the patch applied only trunk, not for branch AOO34 I wasn't familiar with the concept of trunk and branch yet. Though it's not a release blocker, I think most people expect from next release (3.4.1) to fix atmost all bugs, that are detected; they do not want to wait until major release 3.5 or 4.0. So I hope, Your patch for trunk will be soon applied to branch too - Sorry, the user is always impatient.
every trivial bug fix contains a potential risk to break something. In a micro release as we have defined it, only show stopper and security fixes should be integrated. We have many open issues and many are already fixed on trunk. But we don't include them in 3.4.1 because of our definition what goes in a micro release and what not. It will be fixed in 3.5 or 4.0, the next minor or major version depending on our decision what will be next.