Issue 119516 - [From Symphony]a pic in the .doc file cannot display in Aoo 3.4
[From Symphony]a pic in the .doc file cannot display in Aoo 3.4
Product: Writer
Classification: Application
Component: open-import
PC All
: P3 Normal (vote)
: 4.0.0
Assigned To: AOO issues mailing list
Depends on:
  Show dependency treegraph
Reported: 2012-05-29 08:34 UTC by louqle
Modified: 2012-12-26 08:18 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

picture in .doc file (69.00 KB, application/msword)
2012-05-29 08:34 UTC, louqle
no flags Details
patch for the issue (2.27 KB, patch)
2012-06-15 06:18 UTC, Lei Debin
no flags Details | Diff
update the patch (2.30 KB, patch)
2012-06-18 01:56 UTC, Lei Debin
debin.lei: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description louqle 2012-05-29 08:34:02 UTC
Created attachment 77720 [details]
picture in .doc file

open the sample file in Aoo 3.4, the picture cannot display
Comment 1 Lei Debin 2012-06-15 03:17:03 UTC
I am working on it
Comment 2 Lei Debin 2012-06-15 06:11:09 UTC
Root cause found: the sample file was a special one.
Normally one kind of picture is marked with 0x8 0x1 in binary, while in this sample doc the picture field is 0x1 0x1. 
The code did not work for 0x1 0x1 case.
Comment 3 Lei Debin 2012-06-15 06:16:53 UTC
The solution is to process the special case before the usually one.
When we read the 0x1, will try to check the next if 0x1.
If yes, run as normal pic load path, more detail please check the code.
Comment 4 Lei Debin 2012-06-15 06:18:17 UTC
Created attachment 78336 [details]
patch for the issue
Comment 5 Lei Debin 2012-06-18 01:56:35 UTC
Created attachment 78363 [details]
update the patch
Comment 6 Armin Le Grand 2012-06-22 13:22:58 UTC
ALG: Added code, checked, built and tested. Looks good so far, it loads the missing picture. AFAIK this should be good.
Comment 7 Armin Le Grand 2012-06-25 11:47:52 UTC
ALG: Comitted as r1353476, thanks for the patch!
Comment 8 Du Jing 2012-08-21 01:52:16 UTC
verified on the AOO3.5_r1374181