Issue 119521 - [From Symphony]Layout is corrupted in PPT when open in AOO3.4
Summary: [From Symphony]Layout is corrupted in PPT when open in AOO3.4
Status: REOPENED
Alias: None
Product: Impress
Classification: Application
Component: save-export (show other issues)
Version: 3.4.0
Hardware: PC All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 09:03 UTC by Du Jing
Modified: 2012-09-18 02:48 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
sample file (122.00 KB, application/vnd.ms-powerpoint)
2012-05-29 09:03 UTC, Du Jing 		no flags Details
Patch for this issue (1.01 KB, patch)
2012-08-27 06:22 UTC, Jianyuan Li 		lijianyuan1983: review?
Details | Diff
UT file for this issue (435.00 KB, application/vnd.ms-powerpoint)
2012-08-27 06:23 UTC, Jianyuan Li 		no flags Details
compare (28.39 KB, image/jpeg)
2012-09-18 02:48 UTC, louqle 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Du Jing 2012-05-29 09:03:57 UTC 
Created attachment 77730 [details]
sample file

Build: AOO3.4_1327774

Reproduce steps:
1. Open the attachment
2. Check the layout

Problem:
The layout is corrupted.
Comment 1 Du Jing 2012-07-17 06:16:24 UTC 
confirmed,change its status
Comment 2 Jianyuan Li 2012-08-23 03:02:58 UTC 
Looking at this issue...
Comment 3 Jianyuan Li 2012-08-27 06:21:56 UTC 
Background: A paragraph indent should be minimum of paragraph first line indent and paragraph hanging indent. For MS, its tab stop can be less than paragraph indent. But AOO, it cannot.
Root cause: When import tab stop, only paragraph first line indent is considered.
Resolution:  When import tab stop, paragraph first line indent and hanging indent (together as paragraph indent) are both shall be considered. If tab stop offset is greater than paragraph indent, import it.
Limitation: Different behavior for tab in title placeholder. If current text focus is nearly parallel with a tab stop, if a tab key is input, focus will stop for this tab stop in MS. But in AOO, it will stop in next tab stop.
Comment 4 Jianyuan Li 2012-08-27 06:22:49 UTC 
Created attachment 79160 [details]
Patch for this issue
Comment 5 Jianyuan Li 2012-08-27 06:23:59 UTC 
Created attachment 79161 [details]
UT file for this issue
Comment 6 sunying 2012-09-10 02:17:37 UTC 
patch looks good,reviewed and tested.
Comment 7 SVN Robot 2012-09-10 08:22:03 UTC 
"lijiany" committed SVN revision 1382688 into trunk:
#119521# Layout is corrupted in PPT when open in AOO3.4Reported by: Du JingPa...
Comment 8 Jianyuan Li 2012-09-10 09:17:54 UTC 
Bug is fixed
Comment 9 louqle 2012-09-18 02:47:31 UTC 
on XP SP3 against build r1384699, the layout in MS and Aoo is still different. I attached a screenshot
Comment 10 louqle 2012-09-18 02:48:06 UTC 
Created attachment 79542 [details]
compare