Issue 119716 - the chart lost when open the MS2007 docx sample file.
Summary: the chart lost when open the MS2007 docx sample file.
Status: CONFIRMED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: 3.4.0
Hardware: PC All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 08:07 UTC by Du Jing
Modified: 2014-04-01 11:18 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
sample file (20.50 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2012-06-04 08:07 UTC, Du Jing
no flags Details
patch for i119716 (20.19 KB, patch)
2012-09-05 08:12 UTC, Bo.Tian
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Du Jing 2012-06-04 08:07:58 UTC
Created attachment 77927 [details]
sample file

build info:AOO3.4_1327774

Steps:
1.open the sample file in AOO3.4
2.check the chart

defect:
the chart lost,but in MS office it is not.
Comment 1 Terry Yang 2012-06-12 08:26:05 UTC
Repro, changed to confirmed
Comment 2 Bo.Tian 2012-09-05 08:12:14 UTC
Created attachment 79295 [details]
patch for i119716
Comment 3 Bo.Tian 2012-09-05 08:18:12 UTC
I have finish the data convert part of chart import.So the chart of (.pptx)file can display normally now.
Comment 4 bjcheny 2012-09-05 08:28:14 UTC
Please give more detail on your patch, root cause, your solution, its impact if any.

Remember to set your patch review to "?" when upload patch.

Btw, it will be better to change id to "bo.tian" instead.

(In reply to comment #3)
> I have finish the data convert part of chart import.So the chart of
> (.pptx)file can display normally now.
Comment 5 Bo.Tian 2012-09-05 08:48:55 UTC
@bjcheny
It just stopped at  ChartConverter::createDataSequence(), which should return a good converted XDataSequence.
So I get a single row data and convert it ,call InternalDataProvider::createDataSequenceByRangeRepresentationAndRole() handle it.
And lcl_createDataSequenceAndAddToMapByRole() will do the last work, make a row data into single ones and make it a chart data source.
Comment 6 bjcheny 2012-09-05 09:21:22 UTC
Much better for me. 

It looks like an enhancement/feature for chart in docx, other than a simple defect. Thus, would you please send out an enhancement mail in oo-dev mail list, call for discussion, and list your work so far, including wiki, solution, your understanding, and so on.

Thanks for your great work!

(In reply to comment #5)
Comment 7 Bo.Tian 2012-09-06 00:49:21 UTC
(In reply to comment #6)
> Much better for me. 
> 
> It looks like an enhancement/feature for chart in docx, other than a simple
> defect. Thus, would you please send out an enhancement mail in oo-dev mail
> list, call for discussion, and list your work so far, including wiki,
> solution, your understanding, and so on.
> 
> Thanks for your great work!
> 
> (In reply to comment #5)

sorry I commit a wrong thing ....this patch is for pptx file
Comment 8 Bo.Tian 2012-09-06 00:54:06 UTC
(In reply to comment #6)
> Much better for me. 
> 
> It looks like an enhancement/feature for chart in docx, other than a simple
> defect. Thus, would you please send out an enhancement mail in oo-dev mail
> list, call for discussion, and list your work so far, including wiki,
> solution, your understanding, and so on.
> 
> Thanks for your great work!
> 
> (In reply to comment #5)

The patch show be at Bug 115820 ,
https://issues.apache.org/ooo/show_bug.cgi?id=115820
can you help me to move it?

I am also pay attention to docx part.
Comment 9 bjcheny 2012-09-06 05:56:20 UTC
You can re-upload your patch to that bug, and delete the patch here.

I don't know how to move patch between different bugs.

(In reply to comment #8)
Comment 10 bjcheny 2012-09-06 08:59:45 UTC
The patch breaks the build in chart2 module.

Please help check.

/Users/bjcheny/aoo/trunk/main/chart2/source/tools/InternalDataProvider.cxx:787: error: declaration of 'virtual com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence> chart::InternalDataProvider::createDataSequenceByRangeRepresentationAndRole(const rtl::OUString&, sal_Bool)' throws different exceptions
../inc/InternalDataProvider.hxx:140: error: than previous declaration 'virtual com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence> chart::InternalDataProvider::createDataSequenceByRangeRepresentationAndRole(const rtl::OUString&, sal_Bool) throw (com::sun::star::lang::IllegalArgumentException, com::sun::star::uno::RuntimeException)'

(In reply to comment #8)
Comment 11 Tang Meng 2012-09-07 01:09:37 UTC
The patch breaks the build in sc module on windows.

Please help check.

E:/Aoo2/main/sc/source/core/data/documen5.cxx(173) : error C2259: 'ScChart2DataP
rovider' : cannot instantiate abstract class
        due to following members:
        'com::sun::star::uno::Reference<interface_type> com::sun::star::chart2::
data::XDataProvider::createDataSequenceByRangeRepresentationAndRole(const rtl::O
UString &,sal_Bool) throw(com::sun::star::lang::IllegalArgumentException,com::su
n::star::uno::RuntimeException)' : is abstract
        with
        [
            interface_type=com::sun::star::chart2::data::XDataSequence
        ]
        E:/Aoo2/main/solver/350/wntmsci12.pro/inc/offuh\com/sun/star/chart2/data
/XDataProvider.hdl(35) : see declaration of 'com::sun::star::chart2::data::XData
Provider::createDataSequenceByRangeRepresentationAndRole'
E:/Aoo2/main/sc/source/core/data/documen5.cxx(423) : error C2259: 'ScChart2DataP
rovider' : cannot instantiate abstract class
        due to following members:
        'com::sun::star::uno::Reference<interface_type> com::sun::star::chart2::
data::XDataProvider::createDataSequenceByRangeRepresentationAndRole(const rtl::O
UString &,sal_Bool) throw(com::sun::star::lang::IllegalArgumentException,com::su
n::star::uno::RuntimeException)' : is abstract
        with
        [
            interface_type=com::sun::star::chart2::data::XDataSequence
        ]
        E:/Aoo2/main/solver/350/wntmsci12.pro/inc/offuh\com/sun/star/chart2/data
/XDataProvider.hdl(35) : see declaration of 'com::sun::star::chart2::data::XData
Provider::createDataSequenceByRangeRepresentationAndRole'
dmake:  Error code 2, while making '../../../wntmsci12.pro/slo/documen5.obj'
Comment 12 Bo.Tian 2012-09-07 01:10:56 UTC
(In reply to comment #10)
> The patch breaks the build in chart2 module.
> 
> Please help check.
> 
> /Users/bjcheny/aoo/trunk/main/chart2/source/tools/InternalDataProvider.cxx:
> 787: error: declaration of 'virtual
> com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence>
> chart::InternalDataProvider::
> createDataSequenceByRangeRepresentationAndRole(const rtl::OUString&,
> sal_Bool)' throws different exceptions
> ../inc/InternalDataProvider.hxx:140: error: than previous declaration
> 'virtual
> com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence>
> chart::InternalDataProvider::
> createDataSequenceByRangeRepresentationAndRole(const rtl::OUString&,
> sal_Bool) throw (com::sun::star::lang::IllegalArgumentException,
> com::sun::star::uno::RuntimeException)'
> 
> (In reply to comment #8)

Do you rebuild all of it?
Comment 13 Bo.Tian 2012-09-07 01:11:52 UTC
(In reply to comment #11)
> The patch breaks the build in sc module on windows.
> 
> Please help check.
> 
> E:/Aoo2/main/sc/source/core/data/documen5.cxx(173) : error C2259:
> 'ScChart2DataP
> rovider' : cannot instantiate abstract class
>         due to following members:
>         'com::sun::star::uno::Reference<interface_type>
> com::sun::star::chart2::
> data::XDataProvider::createDataSequenceByRangeRepresentationAndRole(const
> rtl::O
> UString &,sal_Bool)
> throw(com::sun::star::lang::IllegalArgumentException,com::su
> n::star::uno::RuntimeException)' : is abstract
>         with
>         [
>             interface_type=com::sun::star::chart2::data::XDataSequence
>         ]
>        
> E:/Aoo2/main/solver/350/wntmsci12.pro/inc/offuh\com/sun/star/chart2/data
> /XDataProvider.hdl(35) : see declaration of
> 'com::sun::star::chart2::data::XData
> Provider::createDataSequenceByRangeRepresentationAndRole'
> E:/Aoo2/main/sc/source/core/data/documen5.cxx(423) : error C2259:
> 'ScChart2DataP
> rovider' : cannot instantiate abstract class
>         due to following members:
>         'com::sun::star::uno::Reference<interface_type>
> com::sun::star::chart2::
> data::XDataProvider::createDataSequenceByRangeRepresentationAndRole(const
> rtl::O
> UString &,sal_Bool)
> throw(com::sun::star::lang::IllegalArgumentException,com::su
> n::star::uno::RuntimeException)' : is abstract
>         with
>         [
>             interface_type=com::sun::star::chart2::data::XDataSequence
>         ]
>        
> E:/Aoo2/main/solver/350/wntmsci12.pro/inc/offuh\com/sun/star/chart2/data
> /XDataProvider.hdl(35) : see declaration of
> 'com::sun::star::chart2::data::XData
> Provider::createDataSequenceByRangeRepresentationAndRole'
> dmake:  Error code 2, while making '../../../wntmsci12.pro/slo/documen5.obj'


I have updated my working copy and I come across the error,too. I am working on it.
Comment 14 Tang Meng 2012-09-07 01:17:39 UTC
If you want to delete attachment, you can
1, click Details.
2, click edit details.
3, select obsolete.
4, submit.
Comment 15 slacka 2013-09-22 23:22:54 UTC
This may be a duplicate of Bug 96426 

It's a serious interoperability issue with MSO. Hopefully someone can look into this.