Issue 119731 - Hyperlink control on dialog editor
Summary: Hyperlink control on dialog editor
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 3.4.0
Hardware: PC All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 12:26 UTC by hanya
Modified: 2019-03-11 18:49 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Proposed patch to add this function (24.89 KB, patch)
2012-06-04 12:26 UTC, hanya
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description hanya 2012-06-04 12:26:10 UTC
Created attachment 77941 [details]
Proposed patch to add this function

css.awt.UnoControlFixedHyperlinkControl is introduced several years ago and xdl file filter supports the element dlg:liklabel. But it can not be loaded 
by the library of basic because of the problem in the export filter. 
The problem is based on "Description" property to export, the implementation 
does not support it and failed to export during to make css::io::XInputStreamProvider.
The attached patch fixes the problem and introduce function to add new 
hyperlink control by the dialog editor.

This patch does not have any icons, existing icons for InsertHyperlink command would be good if they can be reused for InsertHyperlinkControl command.

There is a remained problem about compatibility on the created file by patched office. 
When xld file has dlg:linklabel element, library loader for basic which is not pathed with this fails to 
load the xdl file and residual dialog are not shown in the list of dialogs after 
the problem occured.
Comment 1 jsc 2013-12-18 09:32:36 UTC
needs some deeper look ...
Comment 2 shubhamgoyal 2019-03-10 09:06:24 UTC
I have published changes related to this bug.

Kindly look at
 - https://gerrit.libreoffice.org/#/c/69001/
 - https://gerrit.libreoffice.org/#/c/68952/
Comment 3 Marcus 2019-03-10 21:36:05 UTC
(In reply to shubhamgoyal from comment #2)
> I have published changes related to this bug.
> 
> Kindly look at
>  - https://gerrit.libreoffice.org/#/c/69001/
>  - https://gerrit.libreoffice.org/#/c/68952/

thats great.

If you could tell us that we are allowed to use your changes also for OpenOffice under the Apache License v2 [1], then please give us a clear statement here.

Thanks in advance for your support.

[1] https://www.openoffice.org/license.html
Comment 4 shubhamgoyal 2019-03-11 06:31:27 UTC
Yes, OpenOffice is allowed to use the changes stated in https://bz.apache.org/ooo/show_bug.cgi?id=119731#c2
Comment 5 Marcus 2019-03-11 18:49:28 UTC
Thanks for this. I've changed the issue type to PATCH to make it easier to identify such kind of issues.