Apache OpenOffice (AOO) Bugzilla – Issue 119755
[From Symphony]star and symbol shape in ppt changed after openning by AOO
Last modified: 2012-12-26 07:34:05 UTC
Created attachment 77963 [details] sample file with shape build: AOO3.4 r1327774 steps: 1)open sample ppt file with AOO3.4 2)check shape and compare with MS Office defect: star and symbol shape is different from MS Office
I am working on this issue......
Root Cause: Ellipse ribbon is imported as ribbon. Resolution: 1. Create a new custom shape ellipse ribbon 2. Adjust custom shape structure member(sal_Int16 -> sal_Int32) to adapt ellipse ribbon guide formula parameters(32768).
Created attachment 78774 [details] UT file for this issue
Created attachment 78788 [details] Patch for this issue
ALG: I see the addition of two custom shape geometries which Sven Jacobi marked as todo, this looks great. Why the change of the parameters from sal_Int16 to sal_Int32? I could not find a urgent reason for it. Is it just because it is often used as sal_Int32 anyways?
@Armin: No, this is a must change. In mso_sptEllipseRibbonCalc and mso_sptEllipseRibbon2Calc, you can see a parameter with value 32768 which cannot be contained by sal_Int16. It will become as -32768. And this will result in an incorrect drawing result.
ALG @Jianyuan Li: Thanks for the explanation, I see now. Okay, some more checking, but looks good...
"alg" committed SVN revision 1368033 into trunk: #119755# A new custom shape ellipse ribbon is added and usedPatch by: Jianyua...
The issue has been fixed
verified on XP SP3 and Ubuntu 12.04 against trunk build 1374181
verified in xp, Ubuntu, win7,mac,win7-64,Vista,suse,redhat, SLED 11 SP1 64 bit, all pass. Close this bug.