Issue 119756 - Animation:Text animation play not correct with sample file in AOO
Summary: Animation:Text animation play not correct with sample file in AOO
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: open-import (show other issues)
Version: 3.4.0
Hardware: PC All
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: Armin Le Grand
QA Contact:
URL:
Keywords:
: 119648 119682 119730 120037 120360 (view as issue list)
Depends on:
Blocks:
 
Reported: 2012-06-05 03:14 UTC by Terry Yang
Modified: 2012-07-25 09:20 UTC (History)
10 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+

Attachments
Sample (65.55 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2012-06-05 03:14 UTC, Terry Yang 		no flags Details
Fly In by 1. level (18.86 KB, application/vnd.oasis.opendocument.presentation)
2012-06-05 16:06 UTC, Regina Henschel 		no flags Details
Patch for task in editengine module (4.81 KB, patch)
2012-06-08 10:24 UTC, Armin Le Grand 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Terry Yang 2012-06-05 03:14:19 UTC 
Created attachment 77964 [details]
Sample

Open the sample file, press F5 to start slide show.
At beginning, some text display in the screen, which is not correct.

After click enter, other text display, but there is no any animation.
Comment 1 Regina Henschel 2012-06-05 15:16:36 UTC 
The same problem has already been reported in issue 119756 and discussed on the German mailing list.

The problem is, that each line of a paragraph is treated as complete paragraph. So the animation is done on the lines and not on the paragraphs. Therefore the other paragraphs are already shown, because there are no more animations left over.
Comment 2 Regina Henschel 2012-06-05 15:41:54 UTC 
Wrong issue numbers, should be: Duplicate to issue 119648.

Same problem seems to be in described in issue 119682.

It breaks a lot of presentations and should be fixed soon.
Comment 3 Regina Henschel 2012-06-05 16:06:33 UTC 
Created attachment 78019 [details]
Fly In by 1. level

The attached document has "Fly In" effects assigned to a text box containing three paragraphs. The setting is "By 1. level", so that the three paragraphs should fly in one after the other.

The animation does not move the paragraphs, but the lines of the first paragraph.
Comment 4 Regina Henschel 2012-06-05 16:20:02 UTC 
Animation is OK in Oo3.4beta and in DEV300m106. The earliest build I still have is from around Oct2011 and it shows already some errors in the animation sequence. In that build I get the error:
Error: ImplRenderer::forSubsetRange(): Invalid indices From File Y:/apache/trunk/main/cppcanvas/source/mtfrenderer/implrenderer.cxx at Line 2820
Comment 5 Regina Henschel 2012-06-06 11:18:06 UTC 
*** Issue 119648 has been marked as a duplicate of this issue. ***
Comment 6 Andre 2012-06-08 08:57:36 UTC 
The root cause seems to be in the drawinglayer or below.  When TextHierarchyParagraphPrimitive2D objects are created the text is already split into lines not paragraphs.  It may be the impTextBreakupHandler that give the wrong flags to the edit engine or the edit engine itself, that causes this.
Comment 7 Armin Le Grand 2012-06-08 10:22:41 UTC 
ALG: For OOo3.1 I had fixed #i108052# (see there for details) due to a change in EditEngine behaviour which did no longer handle empty paragraphs (just returns). The reason for this change seems to be changed/fixed again in AOO3.4, so I could simply remove the old fix. I decided to do a fix which does take care of empty paragraphs in a safer way, so that it is only done when not handled before. This will make the fix work independent of if the reason for #i108052# will return or not.
Comment 8 Armin Le Grand 2012-06-08 10:24:02 UTC 
Created attachment 78207 [details]
Patch for task in editengine module
Comment 9 Armin Le Grand 2012-06-08 10:25:15 UTC 
ALG: Added patch as attachment and comitted to trunk as r1348010.
Comment 10 jsc 2012-06-08 12:23:14 UTC 
set release blocker flag for 3.4.1
Comment 11 Armin Le Grand 2012-06-08 12:25:00 UTC 
ALG: Taking ownership
Comment 12 Armin Le Grand 2012-06-08 12:42:51 UTC 
ALG: Merged into branches/AOO34.
Comment 13 Regina Henschel 2012-06-09 15:32:31 UTC 
*** Issue 119682 has been marked as a duplicate of this issue. ***
Comment 14 liuping 2012-06-21 09:27:33 UTC 
confirm fixing the bug on ver 1351249 in Win7 ,pass
Comment 15 Andre 2012-06-25 12:31:35 UTC 
*** Issue 120037 has been marked as a duplicate of this issue. ***
Comment 16 Terry Yang 2012-06-26 06:54:40 UTC 
Verify fixed on AOO 3.4 Branch Dev snapshot rev.1351960 and AOO Trunk Rev. 1351712
Comment 17 Regina Henschel 2012-07-24 20:33:48 UTC 
*** Issue 120360 has been marked as a duplicate of this issue. ***
Comment 18 Regina Henschel 2012-07-24 20:36:37 UTC 
*** Issue 119730 has been marked as a duplicate of this issue. ***
Comment 19 jsc 2012-07-25 09:20:11 UTC 
set target milestone AOO 3.4.1