Issue 119853 - [From Symphony]placeholder in pptx changed in AOO3.4
Summary: [From Symphony]placeholder in pptx changed in AOO3.4
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: formatting (show other issues)
Version: 3.4.0
Hardware: PC All
: P2 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 06:46 UTC by Li Feng Wang
Modified: 2012-09-14 03:12 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
sample file (50.48 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2012-06-07 06:46 UTC, Li Feng Wang
no flags Details
another sample file about page layout (49.36 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2012-06-07 10:19 UTC, Li Feng Wang
no flags Details
Fix patch for this issue (3.64 KB, patch)
2012-09-13 09:04 UTC, Ma Bingbing
jiazema: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Li Feng Wang 2012-06-07 06:46:13 UTC
Created attachment 78094 [details]
sample file

build:
Aoo3.4 r1327774

steps:
1.Launch AOO, open the attached .pptx sample file.
2.Check the placeholder.

Defect: 
placeholder in slide2 and slide4 all changed.
Comment 1 Li Feng Wang 2012-06-07 10:19:04 UTC
Created attachment 78147 [details]
another sample file about page layout

some placeholders in this sample file are lost, then page layout can't display normally.
Comment 2 Ma Bingbing 2012-09-11 03:09:07 UTC
Root Cause:
  Filter pass a placeholder shape with an empty paragraph to presentation, which is recognized as obj other than placeholder.
Comment 3 Ma Bingbing 2012-09-11 03:10:16 UTC
Solution:
  Don't pass the empty paragraph to presentation if it is a placeholder.
Comment 4 Ma Bingbing 2012-09-13 09:04:00 UTC
Created attachment 79483 [details]
Fix patch for this issue
Comment 5 Ma Bingbing 2012-09-13 09:05:33 UTC
the picture place holder isn't contained in this patch which is shown in slide 9 of the 2nd sample file.
Comment 6 bjcheny 2012-09-14 03:12:44 UTC
It's not good to add new parameter for this. I wonder it's possible to query out instead of passing it as parameter. As you may see, it's a bad habit, especially for oox/shape part.