Apache OpenOffice (AOO) Bugzilla – Issue 119963
[From Symphony]TOC should not be updated if load doc in Writer
Last modified: 2012-10-09 09:22:27 UTC
Created attachment 78258 [details] sample Build: AOO 3.4 1. In MS Word 2. Apply heading style to some paragraph 3. Create TOC 4. Remove text content 5. Save doc 6. Open the doc file in Writer Expected Result: TOC should not be updated(The same behavior as MS Word) Actual Result: TOC is updated
hi, all, I have fixed this one, and attached the patch. Please help on reviewing it. Thanks a lot! The whole story of this issue is described in wiki page: http://wiki.services.openoffice.org/wiki/Writer/TOC And the Functional Spec and Detailed Design are also inside this page: FS: http://wiki.services.openoffice.org/wiki/Writer/TOC#Function_Specification DD: http://wiki.services.openoffice.org/wiki/Writer/TOC#Design_Description FYR.
Created attachment 78319 [details] The solution of i119963
I will volunteer reviewing the patch
taking over this issue for the review task
Comment on attachment 78319 [details] The solution of i119963 setting patch review request
Created attachment 78491 [details] sample for TOC loading
Created attachment 78492 [details] sample for TOC loading
Created attachment 78493 [details] sample for TOC loading
Created attachment 78494 [details] sample for TOC loading
Created attachment 78495 [details] sample for TOC loading
Created attachment 78496 [details] sample for TOC loading
Created attachment 78497 [details] sample for TOC loading
*** Issue 175 has been marked as a duplicate of this issue. ***
setting corresponding keyword
Created attachment 78506 [details] The solution of i119963-updated
Comment on attachment 78506 [details] The solution of i119963-updated Patch looks good and works fine in my environment. As discussion is ongoing to work on this enhancement and the following ones on a branch I will not commit this patch.
assigning issue back to zhengfan for further handling.
Created attachment 78973 [details] the third version of the patch The exporting/importing of MS word 2003 doc file are all involved.
Created attachment 79004 [details] 4th version of the patch, with solving some empty paragraph related defects Updated, for review
taking over for reviewing the new patch. @zhengfan: may be some words from your side what additionally is solved by the new patch.
"orw" committed SVN revision 1378038 into branches/writer001: #119963# - WW8 import: import of actual TOC content - first part of TOC enhan...
Applied first part of the patch - import of actual TOC content - on branch writer001. This part of the patch has been already reviewed earlier. Second part of the current patch contains the export of the actual TOC content to WW8 file format (Microsoft Word binary file format). I am currently reviewing this part. Stay tuned.
Comment on attachment 79004 [details] 4th version of the patch, with solving some empty paragraph related defects I have almost finished my review. Patch looks good. I am in discussion with zhengfan on certain details of the patch - mostly to open my mind for learning and understand in detail the changes. As the development is taken place on a branch, I will the second part - export of actual TOC content to WW8 file format - to the branch. I think further development, like the one or the other improvement or correction, will take place in the future on the branch to finalize this enhancement.
"orw" committed SVN revision 1380613 into branches/writer001: #119963# - WW8 export: export of actual TOC content - second part of TOC enha...
Applied second part - WW8 export of actual TOC content - to branch writer001. Future work - already known: - solve defect that under certain conditions a page break is inserted after the imported TOC --> sample document will follow. - target for "TOC hyperlinks" should be internally CrossReferenceBookmarks which would provide better user experience: -- better tooltip on mouse-over -- no visible bookmarks in navigator for these only internally needed bookmarks. - [may be more]
Created attachment 79284 [details] sample to reproduce defect that a page break is inserted after import TOC
Created attachment 79285 [details] tab stop position in TOC content wrong TOC exported to WW8 file format with wrong tab stop position: - open sample text document - export to WW8 file format (Microsoft Word 97/2000/XP) - open in Microsoft Word 2003 or 2010 --> tab stop position of TOC entries for second heading level is wrong --> tab stop position of paragraph with style Content2 is wrong Here we have a general problem: tab stop position are not exported corrected, if paragraph has a left indent
(In reply to comment #27) > Created attachment 79285 [details] > tab stop position in TOC content wrong > > TOC exported to WW8 file format with wrong tab stop position: > - open sample text document > - export to WW8 file format (Microsoft Word 97/2000/XP) > - open in Microsoft Word 2003 or 2010 OR - reopen in AOO > --> tab stop position of TOC entries for second heading level is wrong > --> tab stop position of paragraph with style Content2 is wrong > > Here we have a general problem: > tab stop position are not exported corrected, if paragraph has a left indent
(In reply to comment #28) > (In reply to comment #27) > > Created attachment 79285 [details] > > tab stop position in TOC content wrong > > > > TOC exported to WW8 file format with wrong tab stop position: > > - open sample text document > > - export to WW8 file format (Microsoft Word 97/2000/XP) > > - open in Microsoft Word 2003 or 2010 > OR > - reopen in AOO > > --> tab stop position of TOC entries for second heading level is wrong > > --> tab stop position of paragraph with style Content2 is wrong > > > > Here we have a general problem: > > tab stop position are not exported corrected, if paragraph has a left indent Further investigation reveals that the problem exists, if the tab stop is set at a style. It does not happen, if the tab stop is directly set at the paragraph.
Thanks Oliver for such detailed review. I will take a look for the issue. BTW, whether could we apply the patch in branch 001 and then fix the new found defect?
marking this issue as FIXED - as main work is done
(In reply to comment #25) > Applied second part - WW8 export of actual TOC content - to branch writer001. > > Future work - already known: > - solve defect that under certain conditions a page break is inserted after > the imported TOC --> sample document will follow. > This issue is tracked by bug 120879 > - target for "TOC hyperlinks" should be internally CrossReferenceBookmarks > which would provide better user experience: > -- better tooltip on mouse-over > -- no visible bookmarks in navigator for these only internally needed > bookmarks. > This issue is tracked by bug 120877
"orw" committed SVN revision 1386590 into trunk: #119963#,#120877# - WW8 filter enhancement: import and export actual TOC content
enhancement reintegrated from branch writer001 into trunk.
verified on the build AOO3.5_r1387482
*** Issue 119614 has been marked as a duplicate of this issue. ***
*** Issue 119441 has been marked as a duplicate of this issue. ***
set Target Milestone to AOO 3.5.0 for PM purpose.