Issue 120518 - Remove the "Browser Plug-in" tab page from the Options dialog
Summary: Remove the "Browser Plug-in" tab page from the Options dialog
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 3.4.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: Ariel Constenla-Haile
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 12:34 UTC by Ariel Constenla-Haile
Modified: 2017-05-20 10:31 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+


Attachments
Hide the browser plugin tab page until completely removed (2.64 KB, patch)
2012-08-09 17:52 UTC, Ariel Constenla-Haile
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Ariel Constenla-Haile 2012-08-09 12:34:11 UTC
Revision 1305304 removed the mozilla browser plugin, so Apache OpenOffice does not include it anymore. Nevertheless the "Browser Plug-in" tab page is still there in the "Internet" options on the "Options" dialog (from menu "Tools" - "Options...").
Comment 1 Ariel Constenla-Haile 2012-08-09 12:35:37 UTC
Requesting release blocker status.

This tab page is offering functionality that no longer exists.
Comment 2 jsc 2012-08-09 16:56:54 UTC
not really critical but I would include it in the next build if we have a fix in place.
Comment 3 Ariel Constenla-Haile 2012-08-09 17:50:12 UTC
(In reply to comment #2)
> not really critical but I would include it in the next build if we have a
> fix in place.

There is 

a) the trivial fix of hiding the tab page.

b) the complete removal of the tab page page should include removing all the documentation in the Help files, the configuration items, etc.

(a) is obviously safer.
Comment 4 Ariel Constenla-Haile 2012-08-09 17:52:43 UTC
Created attachment 78897 [details]
Hide the browser plugin tab page until completely removed

The patch hides the browser plugin tab page on every platform, until it is completely removed (source code, configuration, help files, test scripts, etc.)
Comment 5 justineuro 2012-08-10 01:43:57 UTC
(In reply to comment #0)
> Revision 1305304 removed the mozilla browser plugin, so Apache OpenOffice
> does not include it anymore. Nevertheless the "Browser Plug-in" tab page is
> still there in the "Internet" options on the "Options" dialog (from menu
> "Tools" - "Options...").

A link from a user's ~/.mozilla/plugins directory to /opt/openoffice.org3/program/libnpsoplugin.so is also automatically added during the install.
Comment 6 justineuro 2012-08-10 01:48:58 UTC
(In reply to comment #5)
> (In reply to comment #0)
> > Revision 1305304 removed the mozilla browser plugin, so Apache OpenOffice
> > does not include it anymore. Nevertheless the "Browser Plug-in" tab page is
> > still there in the "Internet" options on the "Options" dialog (from menu
> > "Tools" - "Options...").
> 
> A link from a user's ~/.mozilla/plugins directory to
> /opt/openoffice.org3/program/libnpsoplugin.so is also automatically added
> during the install.

... Let me correct myself ... the link was probably added when I chose this option  from the Tools ... Options ... Internet Options tab.  Sorry about that.  Again, thanks much for the claridications.
Comment 7 Ariel Constenla-Haile 2012-08-10 02:35:40 UTC
(In reply to comment #6)
> > A link from a user's ~/.mozilla/plugins directory to
> > /opt/openoffice.org3/program/libnpsoplugin.so is also automatically added
> > during the install.
> 
> ... Let me correct myself ... the link was probably added when I chose this
> option  from the Tools ... Options ... Internet Options tab. 

You are right, that link is created when you check the option in the Options dialog and press OK, and is removed when you uncheck it.

There is nothing we can do during installation or de-installation to remove that link: I'm not aware of any application that touches files in the user directory when installed or removed.
Comment 8 SVN Robot 2012-08-10 12:28:15 UTC
"af" committed SVN revision 1371686 into branches/AOO34:
#i120518# Hide "Browser Plug-in" tab page in options dialog.
Comment 9 Li Feng Wang 2012-08-13 01:53:17 UTC
According comments, I change status to Resolved.
By the way, submit to trunk at the same time is better.
Comment 10 Ariel Constenla-Haile 2012-08-13 05:23:50 UTC
(In reply to comment #9)
> According comments, I change status to Resolved.
> By the way, submit to trunk at the same time is better.

On branch, the tab page is only hidden.
For trunk, we need a proper fix, removing the code completely, not simply hidding the tab page; this was explained in comment 4
Comment 11 Li Feng Wang 2012-08-14 02:42:18 UTC
Verify pass with AOo341 r1372282 on Windows XP,Redhat,Mac.

There is no "Browser Plug-in" in Tools->Options->Internet. Just Hide it.
Comment 12 SVN Robot 2012-08-28 00:53:00 UTC
"arielch" committed SVN revision 1377929 into trunk:
#i120518# - Remove the "Browser Plug-in" tab page
Comment 13 SVN Robot 2012-08-28 00:56:42 UTC
"arielch" committed SVN revision 1377930 into trunk:
#i120518# - Remove the "Browser Plug-in" tab page