Issue 120696 - [From Symphony] The value of the "delay" option can not be kept if save the presentation to a .ppt doc via Symphony.
Summary: [From Symphony] The value of the "delay" option can not be kept if save the p...
Status: CLOSED DUPLICATE of issue 119711
Alias: None
Product: Impress
Classification: Application
Component: save-export (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: ---
Assignee: WangZhe
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-24 06:02 UTC by Steve Yin
Modified: 2012-09-18 02:02 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Fix patch for this issue (496 bytes, patch)
2012-08-24 06:16 UTC, Steve Yin
steve.yin.aoo: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Steve Yin 2012-08-24 06:02:03 UTC
Steps:
1.Launch AOO, new a Presentation document, insert a shape in the doc.
2.Select the shape, set an animation effect for it.
3.Right click the animation effect in "custom animation" sidebar panel, click "effect options" in context menu, switch to "timing" tab, set a value for "delay" option, then click "OK" button.
4.Save the doc as a .ppt document.
5.Reopen the .ppt document then check the value of the "delay" option.

Defect:It is "0.0sec", actually, it should be the value that you set in step 3.
Comment 1 Steve Yin 2012-08-24 06:16:56 UTC
Created attachment 79120 [details]
Fix patch for this issue

Root Cause:
When saving the "Delay" value, the AnimationExporter::exportAnimEvent function use an uninitialized value eTiming.

Resolution:
Just initialize this value  eTiming = Timing_INDEFINITE.
Comment 2 sunying 2012-08-24 07:16:48 UTC
the issue 119711 has the same root cause with this issue.
at line 1381 in file "\main\sd\source\filter\eppt\pptexanimations.cxx",the "if ( eTiming == Timing_INDEFINITE )" is always false, and the nBegin value never is assigned by fTiming. so the "Delay" value always is zero.\

if initialize this value  eTiming = Timing_INDEFINITE, and the "if ( eTiming == Timing_INDEFINITE )" is always true, and the nBegin value alwalys is assigned by fTiming, so Is it necessary to judge eTiming when fTiming has a value?
In my opinion,according in "\main\offapi\com\sun\star\animationstiming.idl", describe the indefinite of Timing:
 enum Timing
{
	/** specifies that a duration, end or start time is indefinite*/
	INDEFINITE,

	/** specifies a simple duration as the intrinsic media duration.
		This is only valid for elements that define media.
	*/
	MEDIA
};
only and if only the eTiming is Timing_INDEFINITE, the animation has a fTiming, so the judgment "if ( eTiming == Timing_INDEFINITE )" may be unnecessary.
@Steve Yin what's your opinion^_^?
Comment 3 WangZhe 2012-09-07 03:27:14 UTC
I'll take this one
Comment 4 WangZhe 2012-09-07 06:07:58 UTC
This defect duplicated with #i119711#

*** This issue has been marked as a duplicate of issue 119711 ***
Comment 5 louqle 2012-09-18 02:02:13 UTC
verified on XP SP3, mac 10.8, Ubuntu 12.04 against build r1384699

verified on RHEL 6.1 64 bit against build 1386464

fixed. Close thid bug