Apache OpenOffice (AOO) Bugzilla – Issue 120885
[From Symphony]Sample file's table border is missing
Last modified: 2012-10-18 05:59:46 UTC
Build: AOO 3.5 Trunk Rev r1381968 OS: All Steps: 1. Open attached sample file Defect: Table border is missing
Created attachment 79484 [details] sample file
Root cause: 1. In style.xml of the sample file, there is a "default" cell style, which applied on the table. In this style, we can see the border properties "fo:border..." in <style:paragraph-properties.../>. So the borders exist in the xml file. 2. When set one property, should check whether it is in the propertySet in stlsheet.cxx (GetStylePropertySet line 82). But the border properties aren't in the propertySet. Then we can't set the value read/write from/to style.xml Solution: add border properties to propertySet for cell style.
Created attachment 79485 [details] Fix patch for this issue
ALG: One question: Why not add the border properties directly to aFullPropertyMap_Impl and to potentially always have them? It's already done for e.g. SPECIAL_DIMENSIONING_PROPERTIES_DEFAULTS and should do no harm.
Created attachment 79528 [details] Patch to just add the border attributes to the standard property set
Comment on attachment 79528 [details] Patch to just add the border attributes to the standard property set ALG: Proposed patch which just adds the missing attributes to the common property set so that they can be preserved
(In reply to comment #4) > ALG: One question: Why not add the border properties directly to > aFullPropertyMap_Impl and to potentially always have them? It's already done > for e.g. SPECIAL_DIMENSIONING_PROPERTIES_DEFAULTS and should do no harm. In my opinion, some style don't have border properties, so I add a new property set for the style which has border.
ALG: This is true, but also for the already added things like CONNECTOR_PROPERTIES and SPECIAL_DIMENSIONING_PROPERTIES_DEFAULTS. Even FILL_PROPERTIES is not needed for all cases. aFullPropertyMap_Impl is used in a more common sense (as the name implies, too), so I would not hesitate to just add the needed properties like the already added ones. It may be nice to have extra property sets here for different shape types, but seems not necessary.
It is all right, thanks for your patch
"alg" committed SVN revision 1387874 into trunk: #120885# Added missing properties for table border to property set to process...
ALG: Okay, committed, done.
Verified pass on build 1397404.
Update Target Milestone to AOO 3.5.0.