Issue 121183 - Page background hatch is very bad in PPT
Summary: Page background hatch is very bad in PPT
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: save-export (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 09:44 UTC by Armin Le Grand
Modified: 2013-07-12 16:25 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Armin Le Grand 2012-10-08 09:44:33 UTC
ALG: To reproduce:
- Open new presentation
- Set page background to any hatch style (context menu on slide, page setup->Background->Hatching->Black 45 deg wide, for all pages)
- save as PPT and reload (or check in PPT)
-> Hatch looks very bad (lloks as if converted to a bitmap with very low resolution)
Comment 1 Armin Le Grand 2012-10-09 12:14:04 UTC
ALG: It is converted to a 28x28 pixel bitmap, probably because it needs to be a fill style for page background. The method used is lclDrawHatch. It may be possible to change this to creation of a bitmap for the whole page, but this would extend the export size unnecessarily.
Comment 2 Armin Le Grand 2012-10-09 15:01:39 UTC
ALG: Found a way to use a MetaFile when exporting a hatch filled background instead of a limited bitmap. This works well and ppt will use and show vector data. This also solves the size and quality problem.
Only caveat is that the roundtrip shows bad quality. After investigation it shows that this is just a visualisation problem; as a result of #119125# any graphic can be used as fill style, but it's usage in SdrFillBitmapAttribute will still always convert it to a BitmapEx. This is a very good target for a further change to keep evtl. metafile and/or svg data down to the primitive usages. Taking a deeper look...
Comment 3 SVN Robot 2012-10-09 15:42:02 UTC
"alg" committed SVN revision 1396082 into trunk:
#121183# enhance export of hatch masterpagebackgrund for ppt format
Comment 4 Armin Le Grand 2012-10-09 15:42:41 UTC
ALG: Basic changes commtted in revision 1396082, taking action on graphic handling stuff...
Comment 5 Armin Le Grand 2012-10-09 16:22:02 UTC
ALG: First step: Buffer evtl. created Bitmap/BitmapEx in ImpGraphic in the local BitmapEx (maEx) when Graphic is a metafile. This is similar to buffering SVG's replacement graphic and pretty straight forward, should workl the same as with svg and avoid multiple renderings.
Comment 6 SVN Robot 2012-10-10 10:19:40 UTC
"alg" committed SVN revision 1396533 into trunk:
#121183# Added buffering non-bitmap formats in Graphic
Comment 7 Armin Le Grand 2012-10-10 10:20:33 UTC
ALG: Okay, done. Now check how to best get more common graphic information down the pipeline...
Comment 8 Armin Le Grand 2012-10-10 13:27:06 UTC
ALG: The change to use vector data in the pipeline is a bigger change, wrote #121194# for it. This task is done.
Comment 9 louqle 2012-11-07 00:42:45 UTC
verified on build 1404513 following the original reproduced steps, pass