Issue 121190 - improve xlsx loading performance by disable 'UpdatePageBreaks' in loading.
Summary: improve xlsx loading performance by disable 'UpdatePageBreaks' in loading.
Status: UNCONFIRMED
Alias: None
Product: performance
Classification: Code
Component: code (show other issues)
Version: AOO400-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 08:02 UTC by lizh.fee
Modified: 2012-10-17 08:18 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
to improve xlsx loading performance (6.48 KB, patch)
2012-10-10 08:47 UTC, lizh.fee 		lizh.fee: review?
Details | Diff
sample (80.79 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2012-10-15 02:43 UTC, lizh.fee 		lizh.fee: review?
Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description lizh.fee 2012-10-10 08:02:52 UTC 
UpdatePageBreaks was called many times wrongly when loading.

Solution:
1. temporarily disable 'UpdatePageBreaks' in WorkbookGlobals::initialize( bool bWorkbookFile )
2. disable 'UpdatePageBreaks' in loading .xlsx format file in function ScTable::UpdatePageBreaks( const ScRange* pUserArea )
3. enable 'UpdatePageBreaks' after loading finish in WorkbookGlobals::finalize()
Comment 1 lizh.fee 2012-10-10 08:47:27 UTC 
Created attachment 79755 [details]
to improve xlsx loading performance
Comment 2 lizh.fee 2012-10-15 02:43:45 UTC 
Created attachment 79773 [details]
sample
Comment 3 lizh.fee 2012-10-15 02:44:37 UTC 
Below is the manual test result on the attached sample.

complex
old:  24.81 24.56 24.62 24.63 24.75   avg:24.67
new:  18.72 18.78 18.75 18.75 18.69   avg:18.74
Comment 4 ChaoHuang 2012-10-17 08:18:43 UTC 
Suggest to put it into AOO 3.5.0 release