Issue 121627 - [GTK] Scrollbars without steppers are buggy
Summary: [GTK] Scrollbars without steppers are buggy
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All Linux, all
: P3 Normal with 1 vote (vote)
Target Milestone: 4.1.1
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 124444 124788 (view as issue list)
Depends on:
Blocks:
 
Reported: 2013-01-15 20:57 UTC by Cosimo Cecchi
Modified: 2017-05-20 10:35 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.0-dev
Developer Difficulty: ---
jsc: 4.1.1_release_blocker+


Attachments
Already reproducible in 3.3 and 3.4 (221.56 KB, image/png)
2014-03-19 20:11 UTC, Ariel Constenla-Haile
no flags Details
Show scroll bars (4.41 KB, patch)
2014-04-02 10:56 UTC, Andre
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Cosimo Cecchi 2013-01-15 20:57:59 UTC
The default GNOME 3 theme for GTK removed the steppers from scrollbars. Unfortunately this breaks the GTK theming layer of OpenOffice.org. See [1] for details.
The summary is that this bug (and more bugs related to scrollbars) is fixed in Libreoffice, which uses a fork of the same GTK theming layer code.

I didn't verify these patches on OpenOffice.org myself, but I believe these should fix the issue [2] [3]. If you're backporting, it might be nice to also backport these other two fixes from Libreoffice related to scrollbars.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=691434
[2] http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=b38ee8c8d5bb10ade41d5ee4050ec4fda12fcbd2
[3] http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=c2c8ac28a49fd26e01435e2c2714a7474c23f8a1
[4] http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=092d72a5591283459eb261e26d57ad8ecf1d5280
[5] http://cgit.freedesktop.org/libreoffice/core/commit/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx?id=58d757fd295d48bcd2eef51c2f41f5014c1cda21
Comment 1 Ariel Constenla-Haile 2013-01-15 21:37:23 UTC
(In reply to comment #0)
> I didn't verify these patches on OpenOffice.org myself, but I believe these
> should fix the issue [2] [3]. If you're backporting, it might be nice to
> also backport these other two fixes from Libreoffice related to scrollbars.

LO can (and actually does) take code from OpenOffice, but OpenOffice can't take code from LO due to license conflict.

So, if the original developer isn't willing to contribute his patches to this project, they cannot be included.
Comment 2 Cosimo Cecchi 2013-01-15 21:40:13 UTC
Ariel: thanks for the answer. I'll contact the original patch author and see if this is an option.

Note that this is *not* related to GTK3, it happens with the GTK2 theming layer.
Comment 3 Ariel Constenla-Haile 2013-01-15 21:52:17 UTC
(In reply to comment #2)
> Note that this is *not* related to GTK3, it happens with the GTK2 theming
> layer.

ha, sorry, I wanted to mark GNOME3, as this seems to be a Gnome3 only related bug: it's not reproducible on CentOS 5 with Gnome2 desktop, neither in KDE 4.9 with any of the widget styles, clearlooks, adwaite, etc (OpenOffice does not build any KDE3/4 vcl-plugin, so it is gtk2 application in KDE).
Comment 4 Cosimo Cecchi 2013-01-15 21:55:23 UTC
(In reply to comment #3)

> ha, sorry, I wanted to mark GNOME3, as this seems to be a Gnome3 only
> related bug: it's not reproducible on CentOS 5 with Gnome2 desktop, neither
> in KDE 4.9 with any of the widget styles, clearlooks, adwaite, etc
> (OpenOffice does not build any KDE3/4 vcl-plugin, so it is gtk2 application
> in KDE).

Yeah, it's likely that all the themes you tried use steppers on scrollbars. Adwaita changed scrollbar style for GTK2 only recently (to match the GTK3 version of the theme) - you need at least the version shipped with GNOME 3.6 to reproduce the bug.
Comment 5 Ariel Constenla-Haile 2014-03-19 20:09:42 UTC
*** Issue 124444 has been marked as a duplicate of this issue. ***
Comment 6 Ariel Constenla-Haile 2014-03-19 20:11:08 UTC
Created attachment 82917 [details]
Already reproducible in 3.3 and 3.4
Comment 7 Ariel Constenla-Haile 2014-03-19 20:13:45 UTC
Confirmed in 3.3 and 3.4
Comment 8 Andrea Pescetti 2014-03-19 22:23:24 UTC
On the system where I noticed bug 124444 aka issue 124444 (duplicate of this one) I strangely cannot reproduce the problem with 3.4.1. It's a very standard Fedora 20 installation, with Gnome 3. I never saw the problem on any systems with Gnome 2.

And, with the default configuration (I installed it with a clean dedicated user profile only for this test) I see:
- Fedora 20, Gnome 3.10.2, Adwaita theme: 3.4.1 is OK, 4.0.0 has the bug
- Fedora 18, Gnome  3.6.3, Adwaita theme: 3.4.1 is OK, 4.0.0 has the bug

I'm surprised that 3.4.1 works correctly too, but it definitely does on these two systems (see screenshot in the other issue). Both are 64-bit. In both cases I used the official Italian versions. If any further detail is needed, just ask. Leaving the version at 3.3 since clearly Ariel can reproduce with 3.3. and 3.4 too.
Comment 9 Andre 2014-03-31 09:44:28 UTC
The main problem could be related to wrong bounding boxes.  I looked at the scroll bars of Writer and both scroll bars have bounding box that seem to cover the whole edit view, only excluding the other scroll bar.  The rest of the scroll bar seems to be painted in the center of that area and is probably hidden by the edit view.
Comment 10 Andre 2014-04-02 10:56:40 UTC
Created attachment 83060 [details]
Show scroll bars

This is an experimental patch that fixes the geometry calculations for scroll bars.  It works on Ubuntu with Adwaita, Radiance and Ambience theme.  It also works on Windows 7.  Did not check other platforms.
Comment 11 Andrea Pescetti 2014-04-02 12:37:48 UTC
Thanks Andre, I confirm that the patch works for me on Fedora 19 with GNOME 3 and Adwaita.
Comment 12 jserock 2014-04-27 17:34:56 UTC
Scrollbars are still not visible in AOO 4.1.0 RC4:

    AOO410m18(Build:9764)  -  Rev. 1589052
    2014-04-22 12:11 - Linux x86_64

I'm running 64-bit openSUSE 13.1 with Gnome 3.10.2 desktop.

Did the patch in Comment #10 make it into RC4?
Comment 13 Andrea Pescetti 2014-04-27 18:31:27 UTC
As explained by jsc on the dev list: the patch is experimental. It will not be integrated in OpenOffice 4.1.0. I expect this to be committed to trunk soon and, if it works well, to be integrated in 4.1.1 or in the next release.
Comment 14 Hagar Delest 2014-05-01 15:48:00 UTC
*** Issue 124788 has been marked as a duplicate of this issue. ***
Comment 15 Andrea Pescetti 2014-06-20 07:44:23 UTC
Nominating for 4.1.1. Issue is very annoying for certain Linux users (depending on desktop environment): cursor in scrollbars is invisible.

Patch available, works for me. Has duplicates in Bugzilla.

If approved for 4.1.1, it would be good to commit the patch early in the proscess so that possible side-effects get caught early.
Comment 16 jsc 2014-06-20 07:52:40 UTC
grant showstopper flag, the available fix can help to increase the usability on Linux

I will take care of it
Comment 17 SVN Robot 2014-06-20 10:09:51 UTC
"jsc" committed SVN revision 1604121 into branches/AOO410:
#121627# integrate patch that fixes the geometry calculations for scroll bars
Comment 18 Andrea Pescetti 2014-06-20 11:06:58 UTC
Note that this hasn't been committed to trunk yet, as far as I can see, but only to AOO410.
Comment 19 SVN Robot 2014-06-20 12:05:03 UTC
"jsc" committed SVN revision 1604149 into trunk:
#121627# merge fix from aoo410 branch that fixes the geometry calculations fo...
Comment 20 jsc 2014-06-20 13:45:51 UTC
patch integrated on AOO410 branch and trunk
Comment 21 samalipraveena 2014-07-24 01:28:48 UTC
Tested in Ubuntu 14.04 gnome shell version 3.10.4 theme adwaita. This bug is verified fixed.