Issue 121731 - modify XSmartTagAction->getCount
Summary: modify XSmartTagAction->getCount
Status: CLOSED FIXED
Alias: None
Product: App Dev
Classification: Unclassified
Component: api (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Normal
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 121391
  Show dependency tree
 
Reported: 2013-02-07 15:49 UTC by labusch
Modified: 2017-05-20 09:32 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch file (2.18 KB, patch)
2013-02-07 15:49 UTC, labusch
no flags Details | Diff
patch file (3.72 KB, patch)
2013-03-20 08:58 UTC, labusch
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description labusch 2013-02-07 15:49:14 UTC
Created attachment 80224 [details]
patch file

Modify the signature of  XSmartTagAction->getActionCount so that it has the corresponding XStringKeyMap as additional parameter.
This modification enables us to vary the number of context menu entries based on the number of actions which are available for the 
particular flag that has been selected by the user.

I send a more detailed explanation of this patch proposal to dev@openoffice.apache.org.
Comment 1 Rob Weir 2013-03-11 14:59:06 UTC
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob
Comment 2 labusch 2013-03-20 08:58:29 UTC
Created attachment 80439 [details]
patch file

I consider this patch request as relevant for the AOO 4.0 release.
Currently, we have a discussion about this patch request at dev@openoffice.apache.org. 
The title of the thread is "[Call-for-Review] code changes for more powerful smarttag extensions".

Jürgen tried to apply the separate patches to the AOO trunk sources and reported that some of the patch-files were broken. 
Therefore, I have regenerated the patch files and submitted them again.
Comment 3 SVN Robot 2013-03-20 15:18:17 UTC
"jsc" committed SVN revision 1458877 into trunk:
#121731# extend XSmartTagAction->getActionCount with additional parameter to ...
Comment 4 jsc 2013-03-21 15:40:04 UTC
patch reviewed and applied on trunk