Apache OpenOffice (AOO) Bugzilla – Issue 122072
[Sidebar]Can't load line arrow type after setting arrow type
Last modified: 2013-07-11 13:56:05 UTC
Trunk build: r1413470 reproduce steps: 1)Create a new spreadsheet/text document 2)Click View->Toolbars->Drawing to show drawing toolbar 3)insert a new line 4)set arrow type for line front and end in Line of sidebar 5)click other location 6)refocus on line created in step3 7)check arrow type on sidebar defect: Expect result: arrow type can display on sidebar and same as arrow type set in step 4. Actual result: arrow type can't display on Line of sidebar. Note: This issue exist on spreadsheet and document, not presentation.
After change line arrow in line tab of context menu, arrow style still not update.
ALG: Indeed, thats the case. Grepping...
ALG: Seems as if the slots SID_ATTR_LINE_START and SID_ATTR_LINE_END are mapped to the wrong StateMethods in SC and SW; in SC they currently use GetAttrFuncState while e.g. SID_ATTR_LINE_DASH (which works) uses GetDrawAttrState. Changing SID_ATTR_LINE_START and SID_ATTR_LINE_END to use GetDrawAttrState works. Same seems true for SW, taking a look. The slots exist for some time (no new slots for sidebar), but the GetState methods were not used in the UI before.
"alg" committed SVN revision 1468963 into trunk: 122072 map SID_ATTR_LINE_START and SID_ATTR_LINE_END to the correct GetState ...
ALG: Comitted change for SC, looking for SW...
ALG: SW had the same error, corrected, checked, comitted. Done.
"alg" committed SVN revision 1468973 into trunk: 122072 map SID_ATTR_LINE_START and SID_ATTR_LINE_END to the correct GetState ...