Issue 122318 - Colour listboxes are not sorted by colour name
Summary: Colour listboxes are not sorted by colour name
Status: ACCEPTED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 08:07 UTC by Ariel Constenla-Haile
Modified: 2017-05-20 11:27 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Comparison between colour listboxes (115.00 KB, image/png)
2013-05-15 08:07 UTC, Ariel Constenla-Haile
no flags Details
Colour listbox sorted by name (368.39 KB, image/png)
2013-05-15 08:08 UTC, Ariel Constenla-Haile
no flags Details
Colour listbox sorted by name (74.30 KB, image/png)
2013-05-15 08:16 UTC, Ariel Constenla-Haile
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Ariel Constenla-Haile 2013-05-15 08:07:30 UTC
Created attachment 80684 [details]
Comparison between colour listboxes

Up to 3.4.1 colour listboxes were sorted by colour name; well, basically the colour palette was sorted in this way. After merging the Symphony colour palette, the colour listboxes appear a little messy, the colour palette looks like sorted to be displayed in the value sets with a specific row and column numbers.
Comment 1 Ariel Constenla-Haile 2013-05-15 08:08:51 UTC
Created attachment 80685 [details]
Colour listbox sorted by name

When the colour palette is sorted in a way similar as before, the lisbox looks better (but the value set not)
Comment 2 Ariel Constenla-Haile 2013-05-15 08:16:08 UTC
Created attachment 80686 [details]
Colour listbox sorted by name

(Cropped screen-shot for better visualisation)

Apply the patch in attachment 80683 [details] and remove the palette in the user/share directory to get this palette sorted by name.
Comment 3 Ariel Constenla-Haile 2013-05-15 08:17:42 UTC
Setting as enhancement.
Comment 4 Armin Le Grand 2013-05-15 10:20:06 UTC
ALG: If the old palette was sorted by name this is pure coincidence, alone because the color names are different in every language (potentially).
The new one is organized using a 12-column layout by porpose, this makes orientation much simpler in the palette popups. Since the trend goes to the color popup (better overview, faster selection) the color dropdowns are not a good argument; indeed I would suggest to replace them with the color popup in one of the next versions (after 4.0).
There is also a feature task (dont know by mind now) which is about having multiple palettes; in the popup this would mean to start a new line when a new palette starts. At this point latest sorting by name would not work anymore.
Ariel, I am not for sorting by name, sorry. I think the 12-column layout is much easier to work with.
Also checked a 3.4.1 version in english, palette starts with

Blac
Blue
Green
Turquoise
Red
Magenta
Brown
...

-> not sorted
Comment 5 Armin Le Grand 2013-05-15 10:52:54 UTC
ALG: What is the difference to #122317# here?
Ariel, I seem to have got the 'sorting' wrong here. You did not talk about sorting the whole palette by names as it seems.
Thanks for checking the used resources. The fallback when no palette file is there still builds up the old palette; this case is the exception and can happen only when the installation is messed up or the user did something wrong. The case that people add their own palette file (or load one) is more often than that, then the used palette would anyways be different from the fallback. Thus, I decided to not touch the fallback, but in principle it should create the new palette; maybe a good occasion to adapt it now and cleanup the resources.
Thus, you are right with the cases (a) - (e) in the other task, but please no resorting. I will take a look and evtl. adapt the default creator, too.
Comment 6 Armin Le Grand 2013-05-15 13:20:26 UTC
ALG: Adapted the default creator, checked and removed quite some old resources. Adapted resource names to RID_SVXSTR_COLOR_* pattern.

I see now what you menat with sorting; the old palette had the same color tones in groups, the new one has groups of twelve colors in different brightnesses. I see now what you mean with sorted in drop-down lists and undeerstand what you mean with 'looking better'.
From my POV it does not look better; it depends what you intend when opening the list box: Do you look for the same color in another brightness (then the old is better) or a different color which would fit from the brightness to the current one (then the new one is better)? Together with the better overview in the ColorPicker I would prefer to stay with the current palette.
Checking some more resource constraints, esp. for what SvxUnoColorNameResId and SvxUnoColorNameDefResId tables are used...
Comment 7 Armin Le Grand 2013-05-15 13:25:18 UTC
ALG: For point (c) ("Blue nine" should be renamed to "Blue 11"): The 'Blue nine' is the old 'Blue 9' which was the default color for the AOO3.* and is the default color for 4.*, too. Thus, I would not call it 'Blue 11' and add it to the group of blue shades, but give it a 'better' name, e.g. 'Blue classic'. It is potentially often used (due to being default). Renaming to 'Blue nine' was just to have no collision with the new 'Blue 9'. Anyone has a better name?
Comment 8 SVN Robot 2013-05-15 14:39:40 UTC
"alg" committed SVN revision 1482867 into trunk:
i122318 Adapted color palette stuff, some cleanups
Comment 9 Armin Le Grand 2013-05-15 14:49:19 UTC
ALG: Comitted changes so far. Ariel, thanks for bringing this up! Kepping open for a while to see if something else comes up...
Comment 10 Ariel Constenla-Haile 2013-05-15 16:38:16 UTC
(In reply to comment #5)
> ALG: What is the difference to #122317# here?

Sorry for not being clear on that one.

Bug 122317 is for tracking the missing resource strings. Without the missing strings the respective colours will stay in English: all comes down to SvxUnogetInternalNameForItem() in svx/source/unodraw/unoprov.cxx, the palette is loaded from the XML file, English name are replaced by they proper translation, but this works only when there are resource string for all colours (well, not for all, in the case of "SomeColourName N" only "SomeColourName" need to have a resource string) and the IDs are in place in SvxUnoColorNameDefResId and SvxUnoColorNameResId.

Bug 122317 is a release blocker, and introduces new strings to be translated.
Bug 122318 is just an *enhancement* in the way colours are sorted in the listbox, compared to 3.4.1


> Ariel, I seem to have got the 'sorting' wrong here. You did not talk about
> sorting the whole palette by names as it seems.

No, I was talking only about the numbered colours:

"Colour 1"
"Colour 2"
"Colour 3"

Look at the screen shots, in the old palette, they where sorted
http://svn.apache.org/viewvc/openoffice/trunk/main/extras/source/palettes/standard.soc?revision=1413471&view=markup

Red 1
Red 2
...
Red 8
Magenta 1
Magenta 2
...
Magenta 8

> Thus, you are right with the cases (a) - (e) in the other task, but please
> no resorting.

This bug is not about sorting the colour palettte by name. It just about the colour listbox.
If you look at the screen shot, colours in the listbox are easy to find in 3.4.1: if the user is trying to find a green or a red, all green 1-8 are together, the same for red 1-8, etc. With the new colour palette, the listbox is not as easy to find because most numbered versions of the colours end up sorted together by number, the screen shot is clear in this case: all XXX 8 are together, all XXX 9 are together, and so on.

@Armin: note that I set the bug type as ENHANCEMENT, as you cannot make them all "happy", the colour value, colour listbox, and the user defined palette on the other hand.
Comment 11 Armin Le Grand 2013-05-16 08:56:40 UTC
ALG: Hi Ariel, thanks for the extended infos. I know about that translation stuff and added the needed ressources/removed unused ones, so this should be done.

About the 'sorting' (let' keep the name, we know now what it's abuout): Seen from the ColorPopup it's about having the lines 1..10 oriented horizontally or vertically. In principle the old palette had them horizontally, thus showing numbered colors close together, the new one is vice-versa. It cannot simply be transposed, we have 12 columns and 11 colors of each type. When going to 11 colums we would have to remove one of the white to black colors which are 12, too.

>if the user is trying to find a green or a red, all green 1-8 are together, 
>the same for red 1-8, etc.

True, but also means that the user has to scroll to find the other colors; he gets offered various brightnesses of one color. In the new layout he has different colors in one fitting brightness together.
Both have pros and cons, I see no real disadvantage in the new one. And as said, I would opt to replace the ListBoxes with the ColorSelector in a next version anyways (4.1?). How about writing an enhancement request for that?
Comment 12 Armin Le Grand 2013-05-27 09:44:08 UTC
ALG: Hi Ariel, do you still see needed action on this one? Maybe keep as enhancement, but change title to show that we intend to change the color ListBoxes to the ColorPopUps completely in one of the next versions...?
Comment 13 Ariel Constenla-Haile 2013-05-27 13:40:36 UTC
(In reply to Armin Le Grand from comment #12)
> ALG: Hi Ariel, do you still see needed action on this one? 

No :)

> Maybe keep as 
> enhancement, but change title to show that we intend to change the color
> ListBoxes to the ColorPopUps completely in one of the next versions...?

IMHO the title is fine (suppose a 4.0.0 user misses the old colour list box with colours grouped by colour name, s/he will may find this report easier, in case s/he is willing to submit a bug).
So this could be closed as WONTFIX (or open a new bug for the list boxes replacement and make this depend on that).
Until list boxes are removed, there is the workaround of using a custom palette with grouped-by-name colours (which is likely not to look good in the colour value set, but you cannot make everybody happy).
Comment 14 Armin Le Grand 2013-05-30 08:15:30 UTC
Okay.

>but you cannot make everybody happy).

True...
Comment 15 Marcus 2017-05-20 11:27:32 UTC
Reset assigne to the default "issues@openoffice.apache.org".