Apache OpenOffice (AOO) Bugzilla – Issue 122591
Link to External Data crash
Last modified: 2017-05-20 11:42:15 UTC
Created attachment 80909 [details] Backtrace - New Calc document - Menu "Insert" - "Link To External Data..." - In the "External Data" dialog, enter http://quickfacts.census.gov/qfd/states/01000.html in "URL of external data source" and press Enter, waiting a few seconds until the "Import Options" dialogue appears - Press OK on the "Import Options" dialogue AOO crashes. Regression introduced by STLport removal. Default constructed map iterators in ScHTMLTableIterator (sc/source/filter/html/htmlpars.cxx) do not have a container, this causes a crash with the iterator's operator== implementation in <xtree>.
Created attachment 80910 [details] Dummy fix Checks the iterator validity with a flag
Created attachment 80911 [details] Another dummy fix Removes ScHTMLTableIterator
set showstopper flag
I wonder, is there any way to search for other occurrences of this kind of problem?
(In reply to Rob Weir from comment #4) > I wonder, is there any way to search for other occurrences of this kind of > problem? The crash happens when uninitialized iterators are dereferenced in MSVC's iterator debugging which is only enabled in developer builds (a.k.a as non-product / dbgutil-enabled builds). On MSVC2008_SP1's xtree the illegal dereferencing is protected by an _Has_container() check. AFAIK there are two ways to search for such problems. A non-product build that was created on a system with such an older MSVC xtree header that doesn't do the _Has_container() check before dereferencing a container is needed for both ways: - run the automatic tests on that build - coverity is good at finding uses of uninitialized stuff and if such a cov-special build was submitted to their scan service there is a chance that it would be reported as medium or high impact problem. Regarding the patches suggested by Ariel either one is fine: the first is minimally invasive and clear whereas the second results in cleaner code as it also removes a quite superfluous class.
taking over to get the Ariel's patch into trunk for AOO 4.0
"orw" committed SVN revision 1498846 into trunk: 122591: correct the iteration on an HTML table
applied patch on trunk for AOO 4.0
Verify Rev. 1499347 on Windows 7