Issue 122649 - Color names not found for translation
Summary: Color names not found for translation
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: formatting (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: hanya
QA Contact:
URL:
Keywords:
: 122650 (view as issue list)
Depends on:
Blocks:
 
Reported: 2013-06-30 07:56 UTC by Pedro Albuquerque
Modified: 2013-12-18 09:37 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.0.0_release_blocker+


Attachments
Color selector translation eror (54.90 KB, image/jpeg)
2013-06-30 07:56 UTC, Pedro Albuquerque
no flags Details
Confirmed with french version (20.48 KB, image/png)
2013-07-02 08:03 UTC, oooforum (fr)
no flags Details
Easy fix patch (1.67 KB, patch)
2013-07-03 11:27 UTC, hanya
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Pedro Albuquerque 2013-06-30 07:56:54 UTC
Created attachment 80956 [details]
Color selector translation eror

Steps for reproduction:
1)Sidebar
2)Properties deck
3)'More options' button
4)Font type, Font effects or Borders tab
5)color selector
6)some of the color names are not translated. I couldn't find them in the project.
Please see attachment.
Comment 1 Ariel Constenla-Haile 2013-06-30 08:24:24 UTC
It looks as if you are using a color palette migrated from 3.4
The color palette in 4.0.0 does not have these colors anymore.
Please check standard.soc in your user profile folder.
Comment 2 Pedro Albuquerque 2013-06-30 08:50:16 UTC
(In reply to Ariel Constenla-Haile from comment #1)
> It looks as if you are using a color palette migrated from 3.4
> The color palette in 4.0.0 does not have these colors anymore.
> Please check standard.soc in your user profile folder.

Thank you. Could you please tell me where that is located?
Comment 3 Ariel Constenla-Haile 2013-06-30 09:03:01 UTC
(In reply to Pedro Albuquerque from comment #2)
> (In reply to Ariel Constenla-Haile from comment #1)
> > It looks as if you are using a color palette migrated from 3.4
> > The color palette in 4.0.0 does not have these colors anymore.
> > Please check standard.soc in your user profile folder.
> 
> Thank you. Could you please tell me where that is located?

In Windows 7:

C:\Users\ariel/AppData\Roaming\OpenOffice\4/user\config\standard.soc

The default palette is under 

C:\Program Files (x86)\OpenOffice 4\presets\config\standard.soc
Comment 4 Pedro Albuquerque 2013-06-30 10:27:09 UTC
(In reply to Ariel Constenla-Haile from comment #3)
> (In reply to Pedro Albuquerque from comment #2)
> > (In reply to Ariel Constenla-Haile from comment #1)
> > > It looks as if you are using a color palette migrated from 3.4
> > > The color palette in 4.0.0 does not have these colors anymore.
> > > Please check standard.soc in your user profile folder.
> > 
> > Thank you. Could you please tell me where that is located?
> 
> In Windows 7:
> 
> C:\Users\ariel/AppData\Roaming\OpenOffice\4/user\config\standard.soc
> 
> The default palette is under 
> 
> C:\Program Files (x86)\OpenOffice 4\presets\config\standard.soc

Ok, I found it. But also found a folder from openoffice 3 at appdata\roaming as well, wich I deleted. I don't know why it was there after uninstalling V.3.4.
I also uninstalled AOO 4 and re-installed again. This solved the issue. Maybe the migration process should prevent this from hapenning.
Comment 5 Pedro Albuquerque 2013-06-30 10:29:50 UTC
Should I do anything else about this issue? Mark it as resolved or something?
Thanks.
Comment 6 Andre 2013-07-01 07:24:01 UTC
@Pedro: Yes, please mark it as resolved (NOTABUG maybe?).  Thank you.
Comment 7 Andre 2013-07-01 07:25:12 UTC
*** Issue 122650 has been marked as a duplicate of this issue. ***
Comment 8 oooforum (fr) 2013-07-02 08:03:32 UTC
Created attachment 80981 [details]
Confirmed with french version

We have 11 color names with "Jaune green..." displayed in the palette.
Comment 9 Pedro Albuquerque 2013-07-02 09:20:06 UTC
Same thing for Portuguese - PT and it seems it's not in Pootle for translations.
Comment 10 hanya 2013-07-02 12:49:16 UTC
In SvxUnoConvertResourceString function, each color names from standard.soc 
are converted from en to target locale. 
Yellow is there before yellow green in the list of the colors. 
So yellow matches with yellow green before expected one.
This is happen for Blue classic also.
Comment 11 Pedro Albuquerque 2013-07-02 15:06:24 UTC
(In reply to hanya from comment #10)
> In SvxUnoConvertResourceString function, each color names from standard.soc 
> are converted from en to target locale. 
> Yellow is there before yellow green in the list of the colors. 
> So yellow matches with yellow green before expected one.
> This is happen for Blue classic also.

You are right but "azul classic" should be "azul clássico", like "amarelo green" should be "amarelo esverdeado". You can consider these two the correct terms.
Neither this nor bug 122648 are release blockers but the translation is still not done.
Comment 12 hanya 2013-07-03 11:27:09 UTC
Created attachment 80985 [details]
Easy fix patch

As easy fix, the attached patch changes the order of the list of color names.
Yellow green is tried to match before yellow. And blue classic and blue are the same manner.
Comment 13 Armin Le Grand 2013-07-04 15:32:02 UTC
ALG: This just changes the order in the SvxUnoColorNameDefResId and SvxUnoColorNameResId, thus the order in the popup color dialogs will not be affected. If it corrects the error (which I will check now) we should take it.
Comment 14 Armin Le Grand 2013-07-04 15:37:46 UTC
ALG: Looks good, the main point that the number and order in SvxUnoColorNameDefResId and SvxUnoColorNameResId is the same to guarantee correct translations from/to translated and non-translated color names is given. Setting request flag.
@JSC: We should add this change
@hanya: Thanks!
Comment 15 jsc 2013-07-05 08:51:04 UTC
grant showstopper issue, fix in place and no translation update necessary
Comment 16 Armin Le Grand 2013-07-05 10:49:09 UTC
ALG: Added some comments and comitted, done. Thanks hanya!
Comment 17 hanya 2013-07-12 17:37:47 UTC
Thanks. Verified on AOO4 RC ja.