Issue 122759 - [cui] "Always save as" list shows internal filter names
Summary: [cui] "Always save as" list shows internal filter names
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 122971 (view as issue list)
Depends on:
Blocks:
 
Reported: 2013-07-16 10:58 UTC by hanya
Modified: 2017-05-20 10:35 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch to fix this problem. (831 bytes, patch)
2013-07-16 13:02 UTC, hanya
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description hanya 2013-07-16 10:58:06 UTC
Tools - Options - Load/Save - General - Default file format and ODF settings 
- Always save as.
This list box shows list of internal filter names. They should be UI names.

AOO400m3(Build:9702)  -  Rev. 1502185
2013-07-11 08:22:42 (Thu, 11 Jul 2013) - Linux i686

In lcl_ExtracUIName function, UIName property of the filter data is extracted 
from sequence< PropertyValue >. Implementation of the function can overwrite 
return value with Name property. It depended on order of the property values 
in the passed sequence.
Version should be AOO4 RC that is going to be 4.0.
Comment 1 hanya 2013-07-16 13:02:55 UTC
Created attachment 81089 [details]
Patch to fix this problem.

If UIName is found, it should be break (commented in the current source, 
I do not know why commented).
To check the value of UIName is string value, break if the extraction is fine.
If no UIName is specified, Name value should be tracked but if the return value 
is still emtpy.
It seems Flags property is not used, that can be removed but not contained in this patch.
Comment 2 SVN Robot 2013-07-17 14:54:12 UTC
"hdu" committed SVN revision 1504159 into trunk:
#i122759# prefer the UIName for the list of "Always save as" filter names
Comment 3 hdu@apache.org 2013-07-17 14:54:48 UTC
Thanks for finding and solving the problem!
Comment 4 jsc 2013-10-15 12:45:08 UTC
*** Issue 122971 has been marked as a duplicate of this issue. ***
Comment 5 SVN Robot 2013-10-15 21:17:30 UTC
"arielch" committed SVN revision 1532536 into trunk:
i122759 - Pass the Sequence by reference
Comment 6 zhaoshzh 2014-04-09 03:32:04 UTC
verified on AOO410m15(Build:9761)  -  Rev. 1585021
Comment 7 zhaoshzh 2014-04-09 07:30:50 UTC
verified on AOO410m14(Build:9760)  -  Rev. 1585624
Comment 8 zhaoshzh 2014-04-09 07:32:15 UTC
verified on AOO410m14(Build:9760)  -  Rev. 1585624