Issue 122982 - Copying spreadsheet into another document in bit map format has disappeared in Version 4. Worked on Version 3.
Summary: Copying spreadsheet into another document in bit map format has disappeared i...
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: formatting (show other issues)
Version: 4.0.0
Hardware: All Windows 8, 8.1
: P3 Normal (vote)
Target Milestone: 4.0.1
Assignee: Armin Le Grand
QA Contact: Akriti
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-08-08 16:07 UTC by dcole
Modified: 2017-05-20 10:34 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.0.0
Developer Difficulty: ---
jsc: 4.0.1_release_blocker+


Attachments
Reopened (139.77 KB, image/png)
2013-09-05 16:19 UTC, Akriti
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description dcole 2013-08-08 16:07:59 UTC
I need to copy formatted spreadsheet information into documents.  In version 3 I could copy the xls spreadsheet and then paste into a document using Edit /Paste Special / Device Independent Bitmap.

When I do this using Version 4, the Edit / Paste Special drop-down list does not include the "Device Independent Bitmap" option or any bit map option.
Comment 1 Edwin Sharp 2013-08-08 18:31:43 UTC
"Device Independent Bitmap" unclear.

Rev. 1503704:
Copy group of cells from ods and paste special as bitmap in odt results in blank read-error object. 

OpenOffice.org 2.4.3:
paste special as bitmap OK.
Comment 2 Armin Le Grand 2013-08-30 11:44:29 UTC
ALG: copying cells from calc, paste-special as bitmap works in draw and impress, calc does something special (as bitmap not available). Fails in Writer (showing a graphic object, when making bigger says 'Read-Error'). Indeed works in 3.4.1 for Writer target.
Comment 3 Armin Le Grand 2013-08-30 12:27:13 UTC
ALG: The inserted object is a writer frame, no SdrGrafObj gets created.
Comment 4 Armin Le Grand 2013-08-30 12:33:35 UTC
ALG: When looking at TransferableDataHelper::GetGraphic the paste thinks that PNG is available and tries to get it. When forcing not to do so, it works. Maybe Calc states there is PNG available, but it is not?
Comment 5 Armin Le Grand 2013-08-30 12:44:01 UTC
ALG: TransferableDataHelper::GetBitmapEx tries to load as PNG despite getting the BMP stream; adding code and checking. This will need deepchecking if all pastes from external as PNG still work. Trying out...
Comment 6 Armin Le Grand 2013-08-30 12:45:46 UTC
ALG: Note: Fine when this works, still wrong that Calc claims that it can offer PNG, though...
Comment 7 Armin Le Grand 2013-08-30 12:52:19 UTC
ALG: Works as intended, also checked insert/as bitmap in draw/impress. Checked all pastes from gimp, Paint.NET and MyPaint, also works well.
Comment 8 Armin Le Grand 2013-08-30 13:28:11 UTC
ALG: Okay, looks good and is plausible. Also a candidate for AOO401, setting flag. Comitted to trunk.
Comment 9 Armin Le Grand 2013-08-30 13:36:32 UTC
ALG: commit has r1518964
Comment 10 SVN Robot 2013-08-30 13:46:15 UTC
"alg" committed SVN revision 1518964 into trunk:
i122982 Fallback to bitmap reader when no PNG even when claimed
Comment 11 jsc 2013-09-02 09:02:46 UTC
approve showstopper request
Comment 12 Armin Le Grand 2013-09-02 09:22:32 UTC
ALG: Also comitted to AOO401, done.
Comment 13 SVN Robot 2013-09-02 09:29:14 UTC
"alg" committed SVN revision 1519374 into branches/AOO401:
i122982 Fallback to bitmap reader when no PNG even when claimed
Comment 14 Armin Le Grand 2013-09-03 10:35:19 UTC
ALG: Corrected owner
Comment 15 Armin Le Grand 2013-09-03 10:36:03 UTC
ALG: Corrected owner
Comment 16 fanyuzhen 2013-09-05 02:49:56 UTC
The latest available build in cwiki is AOO401m2(Build:9711)  -  Rev. 1518667, waiting for the build AOO401 (rev. 1519374) or the later
Comment 17 Akriti 2013-09-05 16:19:16 UTC
Created attachment 81461 [details]
Reopened
Comment 18 Akriti 2013-09-05 16:21:04 UTC
This defect is not fixed in 4.0.1 revison r1518667 .
OS -Win 8

1)Copy group of cell with formatted content to new odt .Paste Special as Bitmap-> Read Error Object appears .snapshot attached
Comment 19 Akriti 2013-09-05 16:21:46 UTC
This defect is not fixed in 4.0.1 revison r1518667 .
OS -Win 8

1)Copy group of cell with formatted content to new odt .Paste Special as Bitmap-> Read Error Object appears .snapshot attached
Comment 20 Armin Le Grand 2013-09-06 08:14:48 UTC
ALG: @Akriti: Surely not, as you see in comment 13, it's in revision 1519374. It cannot be fixed in revision 1518667 wich you used for testing. You were just too fast ;-)
FYI: Apache uses a single, big svn repository which produces a new revision number for each commit. The version you test with needs to be higher than the version the fix went into. The versio the fix went into is normally in one of the comments, you can identify it for AOO401 when it contains that string (e.g. 'branches/AOO401').
HTH and thanks for starting reviewing! Back to fixed until it will be checked on a valid version.
Comment 21 Akriti 2013-09-13 15:02:56 UTC
Verified in r1520285 and its fixed :)