Issue 123091 - [sidebar]: Appearing vertical scroll bar causes decreasing width of elements and double written subtitles
Summary: [sidebar]: Appearing vertical scroll bar causes decreasing width of elements ...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 4.0.0
Hardware: All Windows 7
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-23 22:57 UTC by sevalav
Modified: 2017-05-20 10:34 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.0.0
Developer Difficulty: ---
arielch: 4.0.1_release_blocker?


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description sevalav 2013-08-23 22:57:11 UTC
Viewing problem of subtitles on Sidebar.
The same problem is on Writer, Calc, Draw.

AOO400m3(Build:9702)  -  Rev. 1514218 win7 x64.

Example (look video):
https://docs.google.com/uc?export=download&id=0B_xv-Bc9VISweGlXWUNaUWl6UTQ
Comment 1 Rainer Bielefeld 2013-08-24 06:22:51 UTC
Reproducible with  "AOO 4.0.0-Dev – English  UI / German locale - [AOO410m1(Build:9750)  -  Rev. 1516435  2013-08-24]" on German WIN7 Home
Premium (64bit)", own separate user profile:

1. Launch AOO
2. From AOO Start Center open New DRAW document
3. Draw a matchbox size rectangle (does not matter)
4. increase Sidebar size to maximum
5. click drawn rectangle 
  > Control points appear
6. Collapse Sidebar items at the top: "Insert Shapes" ... Paragraph, Expand
   "Area"+ Line"
   > 'Collapse -> Expand -> Collapse' "Position and Size" should make 
   disappear -> appear -> disappear vertical side bar
7. I necessary try some different collapsed / expanded settings until
   you get disappear -> appear -> disappear vertical side bar
8. Collapse "Position and size"
9. decrease side bar width until dropdown arrow of left electors have disappeared
10. Increase width of sidbar until dropdown arrows of right selectors 
   "Transparency", "Cap Style" are completely visible (but not more )
11. Expand "Position and size"
12.1.  If effect is not visible, 
12.2.  Collapse "Position and size", increase Sidebar width 1/4 dropdown 
       arrow width
12.3   Expand "Position and size"
12.4. If effect is not visible, redo from 12.2

Proceeding should show effect after some attempts

Additional info
-----------------
a) An additional related visible effect is that upcoming vertical sidebar 
   scroll slider decreases width of elements in sidebar, what is unexpected and
   IMHO not intended

@sevalav@gmail.com
What's your operating system?
Comment 2 Rainer Bielefeld 2013-08-24 06:51:53 UTC
b) Already Reproducible with: 
* "AOO 4.0.0 – German UI / German locale  [AOO400m3(Build:9702)  -  Rev. 1503704 2013-07-16 14:54:56 (Di, 16 Jul 2013)]" on German German WIN7 Home Premium (64bit)", Common 4.0-dev User Profile

c) Was still ok with:
* "AOO 4.0.0-Dev – English UI / German locale -  AOO400m3(Build:9702)  -  Rev. 1499347  2013-07-08]" on German WIN7 Home Premium (64bit)", own separate user profile
* server installation of  "AOO 4.0.0-Dev – English UI / German locale [AOO400m1(Build:9700) -  Rev. 1484333 Rev.1483903 (2013-05-20)]" on German WIN7 Home Premium (64bit)", own separate user profile

d) I did not find any relation to properties settings or similar
Comment 3 sevalav 2013-08-24 11:57:36 UTC
(In reply to Rainer Bielefeld from comment #1)

> @sevalav@gmail.com
> What's your operating system?

Windows 7 x64
Comment 4 sevalav 2013-08-24 11:58:31 UTC
(In reply to sevalav from comment #3)
> (In reply to Rainer Bielefeld from comment #1)
> 
> > @sevalav@gmail.com
> > What's your operating system?
> 
> Windows 7 x64

Home Premium
Comment 5 SVN Robot 2013-08-29 07:34:34 UTC
"af" committed SVN revision 1518521 into trunk:
123091: Request repaints of panels on every deck layouting.
Comment 6 Andre 2013-08-29 08:07:57 UTC
The paint error is caused by two things:

a) Text fields not having a background.  They don't have one to make the panels react better to changes of the background color (theme changes, high contrast mode activation/deactivation) and to avoid unnecessary paints and the accompanying flickering.

b) When one panel is expanded or collapsed then all panels in the deck are layouted.  In this instance (collapsing the 'position and size' panel) the height of the remaining panels does not change but their width is modified because the vertical scroll bar vanishes.  For some reason that did not cause a repaint of the panels (an Invalidate() call of the VCL windows).

I have added an explicit Invalidate() call in DeckLayouter::PlacePanels().


Regarding the remaining problem of decreasing width when the vertical scroll bar appears: I am not sure that I understand the problem correctly.  When the scroll bar appears, the available horizontal size that is available for the panels is reduced by the scroll bar width.  The panel content has to be layouted accordingly.  What am I missing?
Comment 7 sevalav 2013-08-30 07:33:50 UTC
I do not know exactly what may be the cause of this. Maybe actions in code are not synchronized. I had some problems in Basic, and wit "Wait" property I solved my problem.
Comment 8 Andre 2013-08-30 09:30:07 UTC
Can you describe the remaining problem?  I don't see what is wrong except the paint errors that have already been fixed.
Comment 9 sevalav 2013-08-30 13:14:41 UTC
(In reply to Andre from comment #6)

> Regarding the remaining problem of decreasing width when the vertical scroll
> bar appears: I am not sure that I understand the problem correctly.  When
> the scroll bar appears, the available horizontal size that is available for
> the panels is reduced by the scroll bar width.  The panel content has to be
> layouted accordingly.  What am I missing?


My comment No 7 was just reaction on your doubt (your comment No6  - look above). I just said one idea which, maybe, can be useful to you.  I still have no installed corrected version with your patch, to somehow help you in practical way.
,
Comment 10 sevalav 2013-09-19 22:49:57 UTC
Problem with double written subtitles is still here.

https://docs.google.com/uc?export=download&id=0B_xv-Bc9VISwcksyaFVWS2hDakU
Comment 11 sevalav 2013-09-19 22:56:33 UTC
(In reply to sevalav from comment #10)
> Problem with double written subtitles is still here.
> 
> https://docs.google.com/uc?export=download&id=0B_xv-Bc9VISwcksyaFVWS2hDakU

I am using AOO401m4(Build:9713)  -  Rev. 1521921
Winsous 7, Home Premium

There is still the same problem. Is the patch for this problem present in this version at all?
Comment 12 Ariel Constenla-Haile 2013-09-19 23:20:46 UTC
(In reply to sevalav from comment #11)
> I am using AOO401m4(Build:9713)  -  Rev. 1521921
> Winsous 7, Home Premium
> 
> There is still the same problem. Is the patch for this problem present in
> this version at all?

It looks like the fix has only been applied to "trunk" (see comment 5).
You can find builds from trunk here: http://ci.apache.org/projects/openoffice/ (select the one in the row "Windows Nightly (aoo-win7)"

Development towards 4.0.1 happens in a so called "branch"; if you want this fix to be available in that branch, you have to request release blocker flag.
Comment 13 sevalav 2013-09-20 13:08:55 UTC
(In reply to Ariel Constenla-Haile from comment #12)

> Development towards 4.0.1 happens in a so called "branch"; if you want this
> fix to be available in that branch, you have to request release blocker flag.

Please, can you do this to me (about request)? Relative I am new here and I do not know how to do that. I was thinking that when something is done, that (patch) is automaticaly inside every new version of AOO..
Comment 14 Ariel Constenla-Haile 2013-09-20 13:29:35 UTC
(In reply to sevalav from comment #13)
> (In reply to Ariel Constenla-Haile from comment #12)
> 
> > Development towards 4.0.1 happens in a so called "branch"; if you want this
> > fix to be available in that branch, you have to request release blocker flag.
> 
> Please, can you do this to me (about request)? Relative I am new here and I
> do not know how to do that. I was thinking that when something is done, that
> (patch) is automaticaly inside every new version of AOO..

Requesting release blocker flag per user request.
There is a fix already committed in trunk, but not merged in the AOO401 branch.

Note: I didn't verify the bug is fixed on trunk, and the bug status is still CONFIRMED.
@sevalav: can you verify if its fixed on the trunk build? Thanks in advice.
Comment 15 jsc 2013-09-20 13:51:04 UTC
remove keyword regression because no regression possible in a new feature.

It's no serious issue and can be easy workaround by resizing the window. The RC3 is built already but if we should need a RC4 we can integrate it.
Comment 16 jsc 2013-09-20 13:57:05 UTC
don't get me wrong, if this issue were coming up earlier I would have granted the shows topper request.

But the issue is not set fixed, not verified etc. and of course not serious
Comment 17 Rainer Bielefeld 2013-09-20 15:38:58 UTC
I easily reproduce the problem with
*  "AOO 4.0.1 RC2  – German UI / German locale  [AOO401m5(Build:9714)  -  Rev. 1523756 2013-09-16 20:50:21]" on German German WIN7 Home Premium (64bit)", Common 4.0-dev User Profile
* "AOO 4.0.0-Dev – English  UI / German locale - [AOO410m1(Build:9750)  -  Rev. 1516435  2013-08-24]" on German WIN7 Home Premium (64bit)", own separate user profile

But I failed to reproduce the problem with  "AOO 4.1.0-Dev – English  UI / German locale - [AOO410m1(Build:9750)  -  Rev. 1523968 - 2013-09-18]" on German WIN7 Home
Premium (64bit)", own separate user profile.

So FIXED for target 4.1.0

@jsc
I agree with rating "not very serious" and your suggestions when fix should be integrated. But I think that is a regression due to Comment 2, the new feature started with that bug.