Issue 123181 - Rhombus are reflected
Summary: Rhombus are reflected
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: open-import (show other issues)
Version: 4.0.0
Hardware: All All
: P3 Major (vote)
Target Milestone: 4.0.1
Assignee: AOO issues mailing list
QA Contact: Prachi
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-09-04 13:49 UTC by efa
Modified: 2017-05-20 10:33 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.0.1_release_blocker+


Attachments
.odg file correctly seen with OO3.x (14.78 KB, application/vnd.oasis.opendocument.graphics)
2013-09-04 13:51 UTC, efa
no flags Details
export of OO3.x rendering of the same file (15.76 KB, image/png)
2013-09-04 13:52 UTC, efa
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description efa 2013-09-04 13:49:59 UTC
I had an .odg file saved with OO3.x
Opening with OO4 get the rhombus reflected
This seems a regression
Comment 1 efa 2013-09-04 13:51:23 UTC
Created attachment 81449 [details]
.odg file correctly seen with OO3.x
Comment 2 efa 2013-09-04 13:52:02 UTC
Created attachment 81450 [details]
export of OO3.x rendering of the same file
Comment 3 Regina Henschel 2013-09-04 14:33:53 UTC
It is an import problem. You see the same error with a file created in AOO4.0.

Import is OK in r1453677, import fails in r1466899.
Comment 4 Regina Henschel 2013-09-04 14:46:09 UTC
Hi Armin, r1465696 looks suspicious.
Comment 5 Armin Le Grand 2013-09-04 15:00:26 UTC
ALG: Indeed, can reproduce. Simple way:
- Start AOO400
- draw a rectangle (CustomShape, not regular)
- shear (e.g. 60)
- save, reload -> shear is at -60, object is 'flipped', keeping it's upper edge but shearing to the opposite side.
- loads correctly in AOO341
Comment 6 Armin Le Grand 2013-09-04 15:16:16 UTC
ALG: Thanks, Regina! Looks as if we looked at the same time ;-)
Definitely has to do with TRGetBaseGeometry/TRSetBaseGeometry and how it handles shear; in SdrTextObj it is *not* converted/mirrored at all, in SdrObjCustomShape it is mirrored in TRSetBaseGeometry (this seems to be the error, #121932# is involved). To make sure I will have to check what the API and the ODF im/export uses...
Comment 7 Armin Le Grand 2013-09-04 15:17:23 UTC
ALG: Adding regression keyword
Comment 8 Armin Le Grand 2013-09-04 15:53:21 UTC
ALG: CHecked and also made sure that in AOO341 the mirroring of fShearX in SdrObjCustomShape::TRSetBaseGeometry was not there. The fix for #121932# here was wrong, the trunk version does not correct the mirrored shear values, neither at the object level, nor on the API or XML level. Taking back the mirroring of the shear angle (maybe I was at aw080 in my thoughts here ;-( )
Comment 9 Armin Le Grand 2013-09-04 15:58:53 UTC
ALG: Comitted fix for trunk, set regression flag for AOO401, done for AOO410
Comment 10 Armin Le Grand 2013-09-04 15:59:54 UTC
ALG:@efa: Many thanks for finding and reporting this!
Comment 11 SVN Robot 2013-09-04 16:17:06 UTC
"alg" committed SVN revision 1520057 into trunk:
i123181 Corrected mirroring of shear angle in SdrObjCustomShape::TRSetBaseGeo...
Comment 12 jsc 2013-09-05 13:15:36 UTC
approve showstopper request
Comment 13 Armin Le Grand 2013-09-09 09:14:57 UTC
ALG: Checked with AOO401 branch and comitted, done.
Comment 14 SVN Robot 2013-09-09 09:21:10 UTC
"alg" committed SVN revision 1521006 into branches/AOO401:
i123181 Corrected mirroring of shear angle in SdrObjCustomShape::TRSetBaseGeo...