Apache OpenOffice (AOO) Bugzilla – Issue 123181
Rhombus are reflected
Last modified: 2017-05-20 10:33:53 UTC
I had an .odg file saved with OO3.x Opening with OO4 get the rhombus reflected This seems a regression
Created attachment 81449 [details] .odg file correctly seen with OO3.x
Created attachment 81450 [details] export of OO3.x rendering of the same file
It is an import problem. You see the same error with a file created in AOO4.0. Import is OK in r1453677, import fails in r1466899.
Hi Armin, r1465696 looks suspicious.
ALG: Indeed, can reproduce. Simple way: - Start AOO400 - draw a rectangle (CustomShape, not regular) - shear (e.g. 60) - save, reload -> shear is at -60, object is 'flipped', keeping it's upper edge but shearing to the opposite side. - loads correctly in AOO341
ALG: Thanks, Regina! Looks as if we looked at the same time ;-) Definitely has to do with TRGetBaseGeometry/TRSetBaseGeometry and how it handles shear; in SdrTextObj it is *not* converted/mirrored at all, in SdrObjCustomShape it is mirrored in TRSetBaseGeometry (this seems to be the error, #121932# is involved). To make sure I will have to check what the API and the ODF im/export uses...
ALG: Adding regression keyword
ALG: CHecked and also made sure that in AOO341 the mirroring of fShearX in SdrObjCustomShape::TRSetBaseGeometry was not there. The fix for #121932# here was wrong, the trunk version does not correct the mirrored shear values, neither at the object level, nor on the API or XML level. Taking back the mirroring of the shear angle (maybe I was at aw080 in my thoughts here ;-( )
ALG: Comitted fix for trunk, set regression flag for AOO401, done for AOO410
ALG:@efa: Many thanks for finding and reporting this!
"alg" committed SVN revision 1520057 into trunk: i123181 Corrected mirroring of shear angle in SdrObjCustomShape::TRSetBaseGeo...
approve showstopper request
ALG: Checked with AOO401 branch and comitted, done.
"alg" committed SVN revision 1521006 into branches/AOO401: i123181 Corrected mirroring of shear angle in SdrObjCustomShape::TRSetBaseGeo...