Apache OpenOffice (AOO) Bugzilla – Issue 123190
CSV import: sticky "from row" leads to truncated or empty imports
Last modified: 2024-01-02 17:34:11 UTC
The "From Row" option should reset to zero or be highlighted/pop up a query to the user if greater than zero. I was unable to get data into OO Calc from CSV files after changing the value to "2000" once. I could not figure out why all my imports were empty. (I was lucky, because if I had done "from row 5" I would have been losing data and be unaware it was happening.)
Please attach CSV file.
Created attachment 81494 [details] Screenshot with explanation I was asked to attach a sample CSV file, but the defect would be true with ANY CSV file. To reproduce: 1) Import a CSV file and set all your import setting, INCLUDING making "From row:" greater than 1. 2) Open a second, different CSV file. Setting are matched to your last import, including "From row:" line. This is easily overlooked and can cause unexpected results. I suggest one of the following solutions A) a warning if >1 to alert user B) an auto-reset to 1 C) only make "sticky" for the same exact filename. D) A color highlight in GUI interface for this area if greater than 1 Method A, the warning, is my preferred solution. (I guess you could include a checkbox asking to suppress the warning on future imports for people who always want to skip row 1, for example.)
See screenshot and explanation.
Thank you for the explanation. From row field having memory even after closing AOO is indeed a bad thing.
> A) a warning if >1 to alert user Might break UI automation, and interfere with users' workflow. > B) an auto-reset to 1 This is probably the easiest to implement. The code appears to be in load_Separators() and save_Separators() in file main/sc/source/ui/dbgui/scuiasciiopt.cxx. > C) only make "sticky" for the same exact filename. Hard to implement, and has privacy/security implications by storing a history of CSV files you opened... > D) A color highlight in GUI interface for this area if greater than 1 That's an interesting option. > Method A, the warning, is my preferred solution. (I guess you could include > a checkbox asking to suppress the warning on future imports for people who > always want to skip row 1, for example.) My preferred ways would be B or D. What do others think?
For the moment I would prefer B.