Issue 123198 - Impress crashes using the sidebar
Summary: Impress crashes using the sidebar
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: 4.0.0
Hardware: Mac Mac OS X, all
: P2 Critical (vote)
Target Milestone: 4.0.1
QA Contact:
Keywords: crash
Depends on:
Reported: 2013-09-05 22:58 UTC by Thorsten Wagner
Modified: 2014-05-15 22:42 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.0.1_release_blocker+

excerpt from OSX crash report for AOO400 (1.99 KB, text/plain)
2013-09-09 11:57 UTC,
no flags Details
excerpt from OSX 10.7 crash report for AOO401-pre r1520285 (2.08 KB, text/plain)
2013-09-09 12:08 UTC,
no flags Details
catch uno exceptions in sfx2::sidebar::TabBar::Item::HandleClick() (449 bytes, patch)
2013-09-10 15:04 UTC,
jsc: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Thorsten Wagner 2013-09-05 22:58:57 UTC
Impress crashes when selecting properties in the sidebar after using styles.

Steps to reproduce:

(1) Open empty presentation

(2) Select the title frame

(3) Select "Sytles" using the sidebar

(4) Apply style "Subtitle" to the selected frame by double clicking

(5) Select "Properties" using the sidebar

Impress crashes when selecting "Properties" (step 5).
Comment 1 Rainer Bielefeld 2013-09-06 04:30:02 UTC
NOT reproducible with  "AOO 4.1.0-Dev – English  UI / German locale - [AOO410m1(Build:9750)  -  Rev. 1516435  2013-08-24]" on German WIN7 Home
Premium (64bit)", own separate user profile.

MAC related? Related to particular version? Wrong proceeding?

@Thorsten Wagner:
a) what Rev. did you test?
b) It might be useful to have a more precise step by step instruction. For it
   might be important how you open the new presentation: with or without
   wizard? From Star Center, File dialog, rightclick File Explorer? ...?
Comment 2 Thorsten Wagner 2013-09-06 07:08:24 UTC
Revision 1518667 has been tested, but the bug appears in earlier revisions as well as in version 4.0.0 too.

The but may be Mac related, but this is not confirmed. It appears using OS/X 10.8 and is reproducable on different Mac systems.

The empty presentation has been opened using the start center without a wizard. When opening a file using the finder the bug appears too.
Comment 3 Armin Le Grand 2013-09-06 11:04:48 UTC
ALG: Tried on an r1502173 vetrsion on win7, no crash here.
Comment 4 2013-09-09 11:57:42 UTC
Created attachment 81487 [details]
excerpt from OSX crash report for AOO400
Comment 5 2013-09-09 12:08:33 UTC
Created attachment 81489 [details]
excerpt from OSX 10.7 crash report for AOO401-pre r1520285

The crash is also reproducible on the latest AOO401 snapshot on OSX 10.7
Comment 6 2013-09-09 12:11:42 UTC
Confirmed, versions updated, added crash and removed needmoreinfo keywords.
Comment 7 2013-09-09 12:59:04 UTC
Compiling main/sfx2/source/sidebar/TabBar.cxx without optimization solves the problem, recompiling it with optimization reintroduces the problem...
Comment 8 2013-09-10 11:25:44 UTC
When -fno-default-inline is defined then it also doesn't crash even when optimizations are enabled.
Comment 9 2013-09-10 15:04:13 UTC
Created attachment 81509 [details]
catch uno exceptions in sfx2::sidebar::TabBar::Item::HandleClick()

Catching uno exceptions in the TabBar click handler and ignoring them avoids the crash. The patch is intended only as a temporary workaround against the release-critical stability problem.
Comment 10 Thorsten Wagner 2013-09-10 21:01:28 UTC
Unfortunately I'm not able to retest a patch. I need precompiled software, because the 10.4 sdk currently in use for compiling is too old to have it available on my systems. I will retest the workaround as soon as it is available in a snapshot build.
Comment 11 jsc 2013-09-11 08:49:21 UTC
Comment on attachment 81509 [details]
catch uno exceptions in sfx2::sidebar::TabBar::Item::HandleClick()

I have review the patch and applied it locally. The fix works and looks ok to me. Not critical and helps for now to survive.
Comment 12 2013-09-11 08:58:33 UTC
I propose the fix should get into AOO 4.0.1 to solve the stability problem for now. The sidebar functionality doesn't seem to be impacted but this scenario should better be reviewed by our resident sidebar expert.
Comment 13 jsc 2013-09-11 09:15:34 UTC
approve showstopper request
Comment 14 SVN Robot 2013-09-11 09:18:51 UTC
"hdu" committed SVN revision 1521765 into trunk:
#i123198# catch and ignore uno exceptions in sfx2::sidebar::TabBar::Item::Han...
Comment 15 SVN Robot 2013-09-11 10:03:19 UTC
"hdu" committed SVN revision 1521771 into branches/AOO401:
#i123198# catch and ignore uno exceptions in sfx2::sidebar::TabBar::Item::Han...
Comment 16 2013-09-11 10:45:52 UTC
The fix is now in trunk and in the AOO401 release branch. The next snapshot will have them.