Apache OpenOffice (AOO) Bugzilla – Issue 123350
Slide title undo impossible
Last modified: 2017-05-20 10:35:07 UTC
1. File - New - Presentation 2. Add title 3. Click on "Click to add text" 4. Click on slide background 5. Undo Title does not disappear. AOO410m1(Build:9750) - Rev. 1525015 2013-09-24_04:09:45 - Rev. 1525769 4.0.1 RC3 testing
I tried with an additional step "3.1 - Type few words" NOT reproducible with "AOO 4.1.0-Dev – English UI / German locale - [AOO410m1(Build:9750) - Rev. 1523968 - 2013-09-18]" on German WIN7 Home Premium (64bit)", own separate user profile. Very new Regression? Linux related?
I think Linux only bug but need to verify. Was observed on: CPU[-Quad AMD A6-3420M APU with Radeon HD Graphics clocked at 800.000 Mhz-] Kernel[-Linux 3.9-0.slh.4-aptosid-amd64 x86_64-] Up[-2:07-] Mem[-492.3/3436.4MB-] HDD[-504GB(7%used)-] Procs[-146-] Client[Shell]
NOT reproducible with "AOO 4.1.0-Dev – English UI / German locale - [AOO410m1(Build:9750) - Rev. 1525917 - 2013-09-25]" on German WIN7 Home Premium (64bit)", own separate user profile. That underpins "Linux only" suspect
Updating fields.
Description valid also for: AOO401m5(Build:9714) - Rev. 1524958 2013-09-20 11:54 - Linux x86_64
Confirmed on another PC. Rev. 1524958 Debian
I reproduced the described defect on Windows 7 64bit in AOO 4.0.0 and AOO 4.0.1, but not in AOO 3.4.0 and AOO 3.4.1. --> platform = All --> version = 4.0.0 --> latest confirmation on = 4.0.1 my steps: - new presentation document with default slide title and slide text placeholder text frames - click into slide title and type some text - click into slide text - click on slide background --> only one Undo action - namely "Edit text of Text Frame 'Click to...'" The important thing to reproduce the defect is that you need to click into slide text while the cursor is still blinking in slide title. You need to switch from editing the slide title directly to the editing of the slide text. in AOO 3.4.0 and AOO 3.4.1 two Undo actions are created - namely: - "Edit text of Text Frame 'Click to...'" - "Edit text of Title text 'Click to...'"
ALG: Has nothing to do with thext edit or changing directly from one text edit to another one. Whatever is onthe undo stack, when activating the PresObj and ending this text edit (adding text or not) the undo stack is gone - only one text edit action remains (which seems to do nothing because pre and post use the 'Click here to ...' text). Checking deeper...
revert Armin's changes to fields 'Version', 'Hardware' and 'Latest Confirmation on'
ALG: Has to do with #120498# where I changed the Text undo. The outliner for text edit gets the undo manager set from the current model to allow smooth continued action when the user uses CTRL-Z in text edit and the last text edit command is already undone -> end text edit and continue undoing the last action. Problem is that with PresObjs (the predefined text objects in impress) the Outliner pretty often triggers a Clear() at the undo stack. If this undo stack is the already set global one, too much is cleared. There are two possible solutions: (1) overload Clear() in SdrUndoManager and clear only up to the TextEdit's start point where itis undo stack was set (works, just added that code) (2) remove #120498# and solve much simpler Implemented (1) and it works, will commit that. I will also take the time and check if (2) is doable, this would make things much easier. Less complicated is always better.
"alg" committed SVN revision 1530254 into trunk: i123350 Added Clear() implementation to SdrUndoManager to only delete text ed...
ALG: Checked possibility (2), but there are caveats: - The DropDown UndoStack would only show the TextEdit undos - Only these would be undoable in one run, no selection of longer list - The State/Execute methods of UNDO/REDO would need to be faked to do the right thing (e.g. also to show the redos when in TextEdit but no undos, etc.) There are probably more, thus the current solution (1) with exchanging the undo stack but limiting it's clearance to text edit bounds, is preferrable. This is comitted, thus this task is done.
verified on AOO410m15(Build:9761) - Rev. 1585021
verified on AOO410m14(Build:9760) - Rev. 1585624