Issue 123573 - Shapes only accept new area properties after rotation, Format Toolbar and Shape color mismatch
Summary: Shapes only accept new area properties after rotation, Format Toolbar and Sha...
Alias: None
Product: Draw
Classification: Application
Component: editing (show other issues)
Version: 4.1.0-dev
Hardware: All Windows 7
: P3 Critical (vote)
Target Milestone: 4.1.0
Assignee: Armin Le Grand
QA Contact:
Keywords: regression
Depends on:
Reported: 2013-10-29 05:25 UTC by Rainer Bielefeld
Modified: 2017-05-20 10:35 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Note You need to log in before you can comment on or make changes to this issue.
Description Rainer Bielefeld 2013-10-29 05:25:09 UTC
Steps how to reproduce with  "AOO 4.1.0-Dev – English  UI / German locale - [AOO410m1(Build:9750)  -  Rev. 1534248 - 2013-10-22]" on German WIN7 Home
Premium (64bit)", own separate user profile:

1. From AOO start center open Attachment 81812 [details] for Bug 123515
2. click white shape at X/Y 70/83mm (right from trapezoid koala bear shape
   > Control points appear, Format Toolbar shows "Color = White" for area
3. In Format Toolbar change color to "Yellow" (or something else, does not 
   Expected: Shape area changes to selected color "Yellow"
   Actual: Selector shows yellow, but shape stays white
4. Second click on shape
   > 'Rotate' control points appear
5. Click top right 'Rotate' control point
   > newly selected color appears for shape area. New color will stay if you
     rotate shape a little or switch back to white if you do not rotate

Additional information:
(a) an other effect, probably related:
    Repeat test starting with step 1, but 
    in Step 3 first change "Color" selection to "Hatching", then "Color white"
    to hatching black 0°
    Unexpectedly selection switches back to "Color = White"
(b) after (a) continue with test
    In step 5 in rotated shape hatching will appear, but selector in Format 
     area toolbar still shows "Color = White"
(c) effect (a), (b) also with Gradient, Bitmap
Comment 1 Rainer Bielefeld 2013-10-29 05:31:56 UTC
Seems that this one is a much more simple DRAW "Basic Shape" problem:

With 4.1-dev redo test from original report, but not with sample document, but with a blank new Drawing created from AOO Start Center Button with a new Basic Shape "Diamond" drawn by you.
All effects from original report (a), (b) and color change only after rotation will be reproducible.
Comment 2 Rainer Bielefeld 2013-10-29 05:39:08 UTC
(d) Already Reproducible with server installation of "AOO 4.1.0-Dev – 
    English  UI / German locale - [AOO410m1(Build:9750)  -  Rev. 1525917 - 
    2013-09-25]" on German WIN7 Home Premium (64bit)", own separate user profile.

(e) was still ok with server installation of "AOO 4.1.0-Dev – English  UI / 
    German locale - [AOO410m1(Build:9750)  -  Rev. 1523968 - 2013-09-18]" 
    on German WIN7 Home Premium (64bit)", own separate user profile.
Comment 3 Rainer Bielefeld 2013-10-29 05:59:11 UTC
Also affected: Symbol Shapes, Block Arrows, Flowcharts, Callouts, Stars.

This bug makes Draw more or less unusable, so Critical.
Comment 4 Regina Henschel 2013-10-29 07:12:05 UTC
Only custom shapes are affected. The error is not only with area, but with line and extrusion on/off too. The shape gets the new property, but it is drawn only after the path of the shape changes for example by handle, or rotation, or resizing. The new property is saved and is visible after reload. It is not a simple screen refreshing problem, move or hide/show the shape doesn't help.
Comment 5 Regina Henschel 2013-10-29 07:22:03 UTC
undo/ redo makes the new property value visible.
Comment 6 Regina Henschel 2013-10-29 11:40:10 UTC
r1525015 failed too.
Comment 7 Armin Le Grand 2013-10-30 16:38:03 UTC
ALG: Works in AOO401, but indeed broken in trunk. Need to check what may have changed here...
Comment 8 Armin Le Grand 2013-10-31 11:12:52 UTC
ALG: Unifying changes to CustomShapes in the CustomShapeProperties implementation using UpdateTextFrameStatus was too strict; InvalidateRenderGeometry does not only need to be called when TextFrameStatus changes, but in all places where it was called before and when TextFrameStatus changes. Adapted this, checking...
Comment 9 Armin Le Grand 2013-10-31 11:56:03 UTC
ALG: Works as expected, comitting, done. Thanks for finding this; it would have really been bad and shows that looking at dev versions is a necessity!
Comment 10 SVN Robot 2013-10-31 12:00:07 UTC
"alg" committed SVN revision 1537454 into trunk:
i123573 corrected reaction on ItemChanges for CustomShapes
Comment 11 liuping 2014-02-25 01:24:51 UTC
Verify on AOO410m1(Build:9750)  -  Rev. 1570848
Rev.1570848 on windows7 ,Pass