Issue 123753 - WaE: unoedhlp.hxx declaration of 'nId' shadows a member of 'this'
Summary: WaE: unoedhlp.hxx declaration of 'nId' shadows a member of 'this'
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 3.4.0
Hardware: All All
: P5 (lowest) Normal (vote)
Target Milestone: 4.1.0
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-26 08:48 UTC by hdu@apache.org
Modified: 2014-04-01 12:40 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.0.1
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2013-11-26 08:48:04 UTC
Naming method arguments the same as member variables is a bad idea. The compiler is right to warn about this. In the current AOO codebase the problem with the ambiguity of the nId member vs. argument happens 26 times.
Comment 1 SVN Robot 2013-11-26 09:00:16 UTC
"hdu" committed SVN revision 1545571 into trunk:
#i123753# WaE: fix unoedhlp.hxx declaration of 'nId' shadowing a member of Si...
Comment 2 hdu@apache.org 2013-11-26 09:01:23 UTC
Fixed with the commit above.
Comment 3 hdu@apache.org 2014-04-01 12:40:14 UTC
Closing the resolved issue.