Issue 123840 - Fix 32bit/64bit type mismatches for OSX port
Summary: Fix 32bit/64bit type mismatches for OSX port
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 4.1.0-dev
Hardware: All Mac OS X, all
: P3 Normal (vote)
Target Milestone: 4.1.0
QA Contact:
Depends on:
Blocks: 122301
  Show dependency tree
Reported: 2013-12-12 13:11 UTC by
Modified: 2014-04-01 12:24 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Note You need to log in before you can comment on or make changes to this issue.
Description 2013-12-12 13:11:26 UTC
Compiling a codebase in both 32bit and 64bit mode is only possible if the types used are declared and used consistently. E.g. in 32bit mode an int and long pointer may be compatible whereas in 64bit mode these pointers are usually not compatible. Incompatible type conversions need to be fixed.
Comment 1 SVN Robot 2013-12-12 14:11:43 UTC
"hdu" committed SVN revision 1550420 into trunk:
#i123840# fix narrowing conversions in CoreGraphic's array initializers
Comment 2 SVN Robot 2013-12-12 14:14:50 UTC
"hdu" committed SVN revision 1550421 into trunk:
#i123840# fix a 64->32bit narrowing conversion in nss/ciphercontext.cxx
Comment 3 SVN Robot 2013-12-12 14:25:59 UTC
"hdu" committed SVN revision 1550424 into trunk:
#i123840# fix narrow conversions when initializing SC's szMSFilterNames array
Comment 4 2013-12-12 14:30:24 UTC
Other typical problems introduced by 32bit/64bit mismatches are "narrowing conversions" in array initializer lists. C++11 says that they are illegal and some compilers already reject them.

Signed/Unsigned mismatches are similar but the fix for a 32bit/64bit mismatch in an initializer list usually solves the narrowing conversion for signed/unsigned too.
Comment 5 SVN Robot 2013-12-16 16:07:43 UTC
"hdu" committed SVN revision 1551244 into trunk:
#i123840# add and use the sal_GlyphId type
Comment 6 SVN Robot 2013-12-17 15:04:49 UTC
"hdu" committed SVN revision 1551563 into trunk:
#i123840# normalize SalFrame resolution type to sal_Int32
Comment 7 SVN Robot 2013-12-17 16:50:58 UTC
"hdu" committed SVN revision 1551617 into trunk:
#i123840# normalize SalGraphics point count argument types to sal_uInt32
Comment 8 SVN Robot 2014-01-23 16:46:28 UTC
"hdu" committed SVN revision 1560739 into trunk:
#i123840# on 64bit OSX NSRect is a CGRect but not on 32bit
Comment 9 Oliver-Rainer Wittmann 2014-02-10 10:30:32 UTC
@Herbert: Is this issue solved?
Comment 10 SVN Robot 2014-02-20 15:21:03 UTC
"ydario" committed SVN revision 1570218 into trunk:
#i123840# fix name typo in OS/2 code.
Comment 11 SVN Robot 2014-02-24 09:08:03 UTC
"hdu" committed SVN revision 1571189 into trunk:
#i123840# prefer NSZero* constants over open coded altetnatives
Comment 12 2014-02-25 09:12:45 UTC
Fixed with the commits above.
Comment 13 2014-04-01 12:24:21 UTC
Closing the resolved issue.