Apache OpenOffice (AOO) Bugzilla – Issue 123840
Fix 32bit/64bit type mismatches for OSX port
Last modified: 2014-04-01 12:24:21 UTC
Compiling a codebase in both 32bit and 64bit mode is only possible if the types used are declared and used consistently. E.g. in 32bit mode an int and long pointer may be compatible whereas in 64bit mode these pointers are usually not compatible. Incompatible type conversions need to be fixed.
"hdu" committed SVN revision 1550420 into trunk: #i123840# fix narrowing conversions in CoreGraphic's array initializers
"hdu" committed SVN revision 1550421 into trunk: #i123840# fix a 64->32bit narrowing conversion in nss/ciphercontext.cxx
"hdu" committed SVN revision 1550424 into trunk: #i123840# fix narrow conversions when initializing SC's szMSFilterNames array
Other typical problems introduced by 32bit/64bit mismatches are "narrowing conversions" in array initializer lists. C++11 says that they are illegal and some compilers already reject them. Signed/Unsigned mismatches are similar but the fix for a 32bit/64bit mismatch in an initializer list usually solves the narrowing conversion for signed/unsigned too.
"hdu" committed SVN revision 1551244 into trunk: #i123840# add and use the sal_GlyphId type
"hdu" committed SVN revision 1551563 into trunk: #i123840# normalize SalFrame resolution type to sal_Int32
"hdu" committed SVN revision 1551617 into trunk: #i123840# normalize SalGraphics point count argument types to sal_uInt32
"hdu" committed SVN revision 1560739 into trunk: #i123840# on 64bit OSX NSRect is a CGRect but not on 32bit
@Herbert: Is this issue solved?
"ydario" committed SVN revision 1570218 into trunk: #i123840# fix name typo in OS/2 code.
"hdu" committed SVN revision 1571189 into trunk: #i123840# prefer NSZero* constants over open coded altetnatives
Fixed with the commits above.
Closing the resolved issue.