Issue 124131 - use smart pointer's bool operator instead of comparing its content against NULL
Summary: use smart pointer's bool operator instead of comparing its content against NULL
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 4.1.0-dev
Hardware: All All
: P4 Normal (vote)
Target Milestone: 4.1.0
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 122766 122208
  Show dependency tree
 
Reported: 2014-01-28 09:25 UTC by hdu@apache.org
Modified: 2017-05-20 10:35 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2014-01-28 09:25:26 UTC 
Implicit conversions of NULL to e.g. boost::detail::sp_nullptr_t result in warnings that can and should be avoided by using the smart pointers bool operator. This boolean check has to be done explicitly because the bool operator is marked as "explicit" for compilers that support this C++11 feature.
Comment 1 SVN Robot 2014-01-28 14:44:54 UTC 
"hdu" committed SVN revision 1562080 into trunk:
#i124131# use smart pointer's bool operator instead of comparing its content ...
Comment 2 hdu@apache.org 2014-01-28 14:49:32 UTC 
Fixed for boost's smart pointers with the commit above.
Comment 3 hdu@apache.org 2014-04-03 14:34:34 UTC 
Verified: Still fixed in the AOO410 release candidate.