Apache OpenOffice (AOO) Bugzilla – Issue 124158
Update CoinMP
Last modified: 2019-10-12 17:11:40 UTC
We have fixed some issues with CoinMP to allow it to build with the version of clang that ships with OS X 10.9. Currently, the version of CoinMP that ships with Open Office is pegged at 1.6.0. The changes for clang are reflected in the stable version 1.7. Switching to the latest release in this series will allow Open Office to be built with CoinMP under OS X 10.9. The latest source tarball is here: http://www.coin-or.org/download/source/CoinMP/CoinMP-1.7.6.tgz
Adapting summary: Update CoinMP to 1.7.6
Created attachment 82462 [details] Patch to update CoinMP to version 1.7.6 Compiles fine on Linux and Win, untested on Mac
I volunteer to test the patch on Mac ...
coinmp built with the patch but I still get many warnings. I continue a complete build and will test it and will provide some more information about the warnings.
I looks good to me and you can integrate the update on trunk. I tested fro example 110189 and it looked at least ok, the scripts are not working of course but that is different problem
@Ariel, do you plan to integrate the patch on trunk? I can support you and can integrate it, I still have it in my local trunk env.
"arielch" committed SVN revision 1585171 into trunk: i124158 - Update CoinMP to 1.7.6
For tracking: pfg has now committed this patch to the AOO410 branch. Based on the above discussion, this actually seems a good thing to do, but still we want to preserve information on release blockers. This will require some specific testing in the QA phase. For reference, the merge commit is http://svn.apache.org/r1705549 which also contains other portions that will have to be quickly validated on the dev list.
This patch breaks on MacOS and we can't build currently. I have no time to investigate further. I am not sure if it is the patch that I reported some weeks ago that it breaks MacOS. But I remember that I had to revert a CoinMP patch to build on MacOS.
"jsc" committed SVN revision 1705622 into trunk: #124158# rework clang patch to work on MacOS
"jsc" committed SVN revision 1705625 into branches/AOO410: #124158# merge fix from trunk
CoinMP is now updated both on trunk and on the AOO410 branch for OpenOffice 4.1.2.
Is a standard test document available for testing that there are no regressions? Otherwise this should be verified by checking that the solver in Calc still works correctly.
Created attachment 85047 [details] Verification: solver-example.ods Verified with the example we have available at https://wiki.openoffice.org/wiki/Documentation/OOo3_User_Guides/Calc_Guide/Solver Steps to reproduce (this is an extract from the page above): 1) Open solver-example.ods (attached) 2) Tools - Solver, set conditions as per attached screenshot solver-settings.png 3) Click OK The solver gives the expected results (cell C2 is set to 5000), with a very small rounding error that could probably be fixed by modifying iterations or precision. Anyway, the result is the same in an old version like OpenOffice 4.0.1.
Created attachment 85048 [details] Verification: solver-settings.png