Issue 124355 - Useless toolbars in AutoText preview
Summary: Useless toolbars in AutoText preview
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: 3.4.0 Beta (OOo)
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.2.0
Assignee: Oliver-Rainer Wittmann
QA Contact:
URL:
Keywords: regression
Depends on: 124674
Blocks:
  Show dependency tree
 
Reported: 2014-03-04 06:40 UTC by Rainer Bielefeld
Modified: 2017-05-20 10:35 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Screenshot with comments (78.20 KB, application/vnd.oasis.opendocument.graphics)
2014-03-04 06:40 UTC, Rainer Bielefeld
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Rainer Bielefeld 2014-03-04 06:40:24 UTC
Created attachment 82785 [details]
Screenshot with comments

Steps how to reproduce Reproducible with "AOO 4.0.1 Release – German UI / German locale [AOO401m5(Build:9714)  -  Rev. 1524958 2013-09-20 11:40:29]" on German WIN7 Home Premium (64bit)", “historic” 4.0 User Profile used for all predecessor versions:

1. From AOO Start Center open blank new Writer document	
2. <control+f3> (or menu 'Edit -> Autotext')
  > Dialog appears
3. Activate Preview and select an arbitrary list entry
   As expected preview appears
   Bug: inactive useless crippled toolbars above and below preview pane

Additional Info:
(a) Already Reproducible with server installation of "AOO 3.4.0 – German UI 
    / German locale [AOO340m1(Build:9590) - Rev.1327774]" on German WIN7 Home
    Premium (64bit)", own separate user profile
(b) Was still ok with OOo 3.3.0
Comment 1 Rainer Bielefeld 2014-03-04 06:41:31 UTC
Similar or identical: "LibO#37758 - UI: Particular dialogs with preview show useless toolbars " (FIXED)
Comment 2 Oliver Brinzing 2014-03-05 06:07:31 UTC
same problem in mailmerge print dialog. 
custom toolbars are shown around the database browser
Comment 3 Oliver-Rainer Wittmann 2014-03-05 13:55:05 UTC
I can confirm this under Windows 7 and under Ubuntu 10.04 (64bit).
The defect also occurs in OOo 3.4 Beta.

Taking over for a deeper look.
Comment 4 Oliver-Rainer Wittmann 2014-03-05 14:42:48 UTC
Looks like the <ToolbarLayoutManager> does not follow its own 'rules' for hiding/showing its UI elements. See <ToolbarLayoutManager::showToolbar(..)>, <ToolbarLayoutManager::hideToolbar(..)> and <ToolbarLayoutManager::setVisible(..)>

Seems to be solvable.
Comment 5 SVN Robot 2014-03-10 09:37:03 UTC
"orw" committed SVN revision 1575876 into trunk:
124355: Toolbarmanager: correct show/hide of toolbars; correct calculation of...
Comment 6 Oliver-Rainer Wittmann 2014-03-17 07:02:12 UTC
fixed on trunk
Comment 7 mroe 2014-03-27 14:56:32 UTC
Is this fixed for all previews?
Fond the same behaviour for insert/edit TOC after closing and reopening the preview.
Comment 8 Oliver-Rainer Wittmann 2014-03-28 10:27:17 UTC
(In reply to mroe from comment #7)
> Is this fixed for all previews?
> Fond the same behaviour for insert/edit TOC after closing and reopening the
> preview.

I will check it in my local build containing the fix already.
Comment 9 Oliver-Rainer Wittmann 2014-03-28 10:38:39 UTC
(In reply to mroe from comment #7)
> Is this fixed for all previews?
> Fond the same behaviour for insert/edit TOC after closing and reopening the
> preview.

At least this preview is also fixed.

Do you know more previews which I should check?

The fix is made in the toolbar handling, not specific to a certain preview. Thus, I assume that all previews which showed the defect should be fixed. But double-checking is much appreciated. Thus, if somebody knows more previews, not only in Writer, please name them here. I (or somebody installing a nightly buildbot build) can check it.
Comment 10 mroe 2014-03-28 11:17:39 UTC
I don't find a problem with print preview like as comment 2.
But the question is, how to identify the problem if the toolbars not visible but the space it would need like opening the insert/edit TOC dialog first time.

So it could be that there is the same problem at edit page style. There is a little preview of the page with in my opinion to much space to the following list for paper tray. If you change the Orientation from Portrait to (*) Landscape, the page preview becomes bigger but the borders top and bottom are not visible.
But it could be another bug ...
Comment 11 mroe 2014-03-28 11:20:55 UTC
> little preview of the page with in my opinion to much space to the following
> list for paper tray. If you change the Orientation from Portrait to (*)
> Landscape, the page preview becomes bigger but the borders top and bottom
> are not visible.
> But it could be another bug ...

... it is another bug, because same preview will shown at the tabs Header, Footer, Border and Columns. And there is no spacing.
Comment 12 Oliver-Rainer Wittmann 2014-03-28 11:29:05 UTC
(In reply to mroe from comment #10)
> I don't find a problem with print preview like as comment 2.
> But the question is, how to identify the problem if the toolbars not visible
> but the space it would need like opening the insert/edit TOC dialog first
> time.

The defect I have fixed has been introduced in OOo 3.4 Beta. Thus, if you compare recent version with OOo 3.3.0 and you observe a difference in a certain preview, it might be hit by this defect.

> 
> So it could be that there is the same problem at edit page style. There is a
> little preview of the page with in my opinion to much space to the following
> list for paper tray. If you change the Orientation from Portrait to (*)
> Landscape, the page preview becomes bigger but the borders top and bottom
> are not visible.
> But it could be another bug ...

If you enable the enhance language support (Menu Tools - Options - Language Settings - Languages) you will see that in the page style format dialog, pane Page between the preview and the paper tray list box another list box occurs. It is the text direction list box. Thus, this is no defect.
Comment 13 Rainer Bielefeld 2014-03-28 12:01:44 UTC
The same problem does exist for menu 'File -> New -> Business Cards ->  Business Cards (Tab)' (what also has something like an Autotext pane), but my results are different with different Versions: 

 "AOO 4.0.1 Release – German UI / German locale [AOO401m5(Build:9714)  -  Rev. 1524958 2013-09-20 11:40:29]" on German WIN7 Home Premium (64bit)", “historic” 4.0 User Profile used for all predecessor versions: Find + Drawing Toolbar.
After 1 single change from "85x50" To Standard Drawing Toolbar has vanished.
Menu 'Edit -> Autotext' brings back Drawing toolbar

Server installation of "AOO 4.1.0-dev – English UI / German locale - [AOO410m14(Build:9760)  -  Rev. 1577236 2014-03-15]" on German WIN7 Home Premium (64bit)", own separate user profile: Saw only Find Toolbar for some tests, vanished now. Preview pane now is increased, no room for toolbars at top or bottom.
Comment 14 mroe 2014-03-30 11:20:14 UTC
Maybe the same bug:

Using Insert → Frame and insert anything. Always toolbars are visible in the frame.


By the way: Is it the right behaviour, that a picture becomes a draw document in a frame?
Comment 15 Oliver-Rainer Wittmann 2014-04-07 11:40:15 UTC
(In reply to mroe from comment #14)
> Maybe the same bug:
> 
> Using Insert → Frame and insert anything. Always toolbars are visible in the
> frame.
> 

This defect has the same root cause and is also fixed by the made code change.

> 
> By the way: Is it the right behaviour, that a picture becomes a draw
> document in a frame?

I think it is. The same happens, if you open a graphic/image/picture file in OpenOffice.