Issue 124908 - remove custom allocator support in stlport-replacement headers
Summary: remove custom allocator support in stlport-replacement headers
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 4.1.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.1
QA Contact:
Depends on: 124896
Blocks: 123754 124422
  Show dependency tree
Reported: 2014-05-15 12:06 UTC by
Modified: 2017-05-20 10:35 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.1.1_release_blocker+


Note You need to log in before you can comment on or make changes to this issue.
Description 2014-05-15 12:06:19 UTC
The libc++ Xcode>=5.1 runs into problems with such custom allocator wrapping because it considers allocator value_types pair<K,V> and pair<const K,V> as not identical. Since a std::map uses constant keys while most map templates don't ask them to be const the libc++ assertion regarding allocator identicality would trigger often.

With the sal-internal custom allocator removed AOO no longer needs the stlport-replacement headers to support the complexity of containers with non-default allocators. The problems above, their uselessness and the extra complexity introduced by the suggests that they should be removed. Since there are no intra-module uses (and exported symbols) for them everything still remains binary compatible.
Comment 1 SVN Robot 2014-05-15 12:20:22 UTC
"hdu" committed SVN revision 1594887 into trunk:
#i124908# remove custom allocator support in stlport-replacement headers
Comment 2 2014-05-15 13:22:43 UTC
Fixed with the commit above.
Comment 3 jsc 2014-06-12 14:49:17 UTC
grant showstopper flag for AOO 4.1.1

changes are necessary to build the branch on 10.9.x and Xcode 5.1
Comment 4 SVN Robot 2014-06-12 14:56:19 UTC
"jsc" committed SVN revision 1602190 into branches/AOO410:
#124908# merge changes from trunk to be able to build on macos 10.9.3 and Xco...
Comment 5 fanyuzhen 2014-07-07 07:33:39 UTC
It's verified fixed on Windows via build level testing
Comment 6 Kay 2014-07-08 02:07:33 UTC
Verified fixed on r1608485, Linux 32.
Comment 7 Steve Yin 2014-07-23 02:59:41 UTC
Verified on Mac.