Issue 125021 - Descenders get cropped within OS/X widgets
Summary: Descenders get cropped within OS/X widgets
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 4.2.0-dev
Hardware: Mac OS X 10.9
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
Depends on:
Reported: 2014-06-01 16:53 UTC by Thorsten Wagner
Modified: 2014-06-03 20:52 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Patch (1.12 KB, patch)
2014-06-01 16:53 UTC, Thorsten Wagner
no flags Details | Diff
Screenshot without patch (AOO 4.1) (21.60 KB, image/png)
2014-06-01 16:57 UTC, Thorsten Wagner
no flags Details
Screenshot with patch (AOO 4.2) (20.83 KB, image/png)
2014-06-01 16:58 UTC, Thorsten Wagner
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Thorsten Wagner 2014-06-01 16:53:12 UTC
Created attachment 83486 [details]

Using Mac OS/X depending on screen resolution different character heights are calculated:

(1) The calculation of character heights in "ctfonts.cxx" works fine for laptop screens including retina at different resolutions.

(2) For larger cinema displays characters are calculated a little bit too tall. This causes cropping of descenders within widgets (see attached screenshot 1, red boxes).

I supplied a patch with modified roundings. The patch causes character heights to be rounded down to the next pixel instead of rounding to the nearest pixel. The result is shown in attached screenshot 2.

The patch needs to be doublechecked to avoid side effects.
Comment 1 Thorsten Wagner 2014-06-01 16:57:53 UTC
Created attachment 83487 [details]
Screenshot without patch (AOO 4.1)
Comment 2 Thorsten Wagner 2014-06-01 16:58:20 UTC
Created attachment 83488 [details]
Screenshot with patch (AOO 4.2)
Comment 3 2014-06-02 07:48:54 UTC
Comment on attachment 83486 [details]

Added "patch" flag to the attachment to allow easy diff-viewing.
Comment 4 2014-06-02 12:07:17 UTC
Forcing round-down instead of round-nearest results in worse metrics so I'd rather avoid this. Please check whether the rounding fixes for the repaint region (revision 1599173 and revision 1599174) already help for the displays in question.
Comment 5 Thorsten Wagner 2014-06-03 20:52:15 UTC
Unfortunately the fixes in revision 1599173 and revision 1599174 don't solve the problem. The result is still as shown in attached screenshot without patch.

Furthermore the attached patch doesn't solve the problem too. I discovered side effects (characters within status bar become croped and height of tool bars is calculated too small now).