Issue 125477 - MS .doc import regression with table style
Summary: MS .doc import regression with table style
Status: CLOSED DUPLICATE of issue 125163
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P2 Normal (vote)
Target Milestone: ---
Assignee: Armin Le Grand
QA Contact:
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2014-08-21 04:04 UTC by slacka
Modified: 2017-05-20 10:11 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Comparison of Writer 4.1 vs 4.2 (441.11 KB, image/png)
2014-08-21 04:04 UTC, slacka 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description slacka 2014-08-21 04:04:49 UTC 
Created attachment 83865 [details]
Comparison of Writer 4.1 vs 4.2

Steps to reproduce the bug:
1. Open attachment 81153 [details] Demo-Hayden-Management.doc the current master 4.2
2. Open Demo-Hayden-Management.doc Writer 4.1 or earlier 
3. Compare the documents. 

Note that in recent builds the table loses the color shading. 

On Ubuntu 14.4 Version: 4.1.0
AOO410m18(Build:9764)  -  Rev. 1589052
2014-04-22 12:08 - Linux i686
Result: PASS

Version: 4.2.0-dev
AOO420m1(Build:9800)  -  Rev. 1616944
2014-08-20_04:11:31 - Rev. 1619030
Result:FAIL

We need to bisect this bug, but it is likely to stem from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b or 35f3ceaf60f109f45aa7fef7077aead398bed53f
Comment 1 Ariel Constenla-Haile 2014-08-24 23:40:22 UTC 
Confirmed with AOO420m1(Build:9800)  -  Rev. 1616944

Seems to be something with the table cell background color.

In fact, there is no way to set the background color in the cells of Table2 and Table3, both using the toolbar and the dialog, which is Issue 125163; this might be a duplicated.
Comment 2 slacka 2014-08-25 19:54:57 UTC 
This regression is caused by the fixes for Issue 124638 

To verify it occurred between revision 1599233 and revision 1599233 
$ git checkout 1c576ccb46cb22fa2b34ec23144b2b8799e94f57
#125003# migrate sal/qa/osl/condition to gtest 
This is 1 commit behind Revision 1599233
Result: PASS

$ git checkout d5bf989c96b2c7642e66e02cc0e8766df795f371
revision 1599676 :i124638 Corrected paints of Writer Frames with DrawingLayer FillAttributes for all systems and AA/nonAA
Result: FAIL

Could someone get ALG to take a look at this?
Comment 3 slacka 2014-08-25 19:56:01 UTC 
that should read:
occurred between revision 1599233 and revision 1599676
Comment 4 Armin Le Grand 2014-08-26 16:02:44 UTC 
Should be one for me, grepping...
Comment 5 slacka 2014-09-30 06:11:36 UTC 
Caolán McNamara fixed this issue downstream. 

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5aa360cae0383f270c12708e7e94179a7fde6711
Comment 6 Armin Le Grand 2014-10-06 13:12:49 UTC 
@slacka: Yes, but without enhanced fill style support. Anyways, double to issue 125163, see there.

*** This issue has been marked as a duplicate of issue 125163 ***