Issue 125698 - Page background color lines between paragraphs with colored background
Summary: Page background color lines between paragraphs with colored background
Alias: None
Product: Writer
Classification: Application
Component: formatting (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.2.0
Assignee: Armin Le Grand
QA Contact:
Keywords: regression
Depends on:
Reported: 2014-10-01 01:23 UTC by slacka
Modified: 2017-05-20 10:35 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Comparison of background color in 4.1 vs 4.2 (236.98 KB, image/png)
2014-10-01 01:23 UTC, slacka
no flags Details
Sample Document (27.85 KB, application/vnd.oasis.opendocument.text)
2014-10-01 04:50 UTC, Rainer Bielefeld
no flags Details
difference between AOO 4.1.1 and 4.2.0_dev (25.30 KB, image/png)
2014-10-02 16:32 UTC, mroe
no flags Details
printed as PDF (15.50 KB, application/pdf)
2014-10-02 16:32 UTC, mroe
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description slacka 2014-10-01 01:23:08 UTC
Created attachment 84002 [details]
Comparison of background color in 4.1 vs 4.2

Steps to reproduce:
1) Create a new doc in current build of Writer 4.2
2) Select the "Background color" toolbar
3) Change the color to anything other than white
4) Press Return a few times

Expected Results:
A solid block of the selected color

Actual Results:
There is a thin white line between every line.
Comment 1 Rainer Bielefeld 2014-10-01 04:50:09 UTC
Created attachment 84004 [details]
Sample Document

I stumbled upon this one during my tests for "Issue 125699 - No automatic font color adaption to paragraph background color"

Problem is related to paragraph background, not to character (or other)  background colors.

I observe the problem with AOO420m1(Build:9800)  -  Rev. 1623875
Comment 2 Rainer Bielefeld 2014-10-01 04:52:44 UTC
Currently only confirmed for WIN, reporter's OS unknown
Comment 3 Armin Le Grand 2014-10-02 15:04:21 UTC
Probably only a visualization error. Have you tried to force a repaint (zoom or CTRL+ALT+R)?
Comment 4 mroe 2014-10-02 16:32:09 UTC
Created attachment 84008 [details]
difference between AOO 4.1.1 and 4.2.0_dev

Can confirm it for Linux (Ubuntu 64bit).
Also seen in the page preview and in the print preview.
Comment 5 mroe 2014-10-02 16:32:56 UTC
Created attachment 84009 [details]
printed as PDF

Lines are printed too.
Comment 6 Regina Henschel 2014-10-02 17:58:10 UTC
It is good in r1596218, and bad in r1599676.

If you turn off anti-aliasing, it is drawn correctly.

The problem has likely been introduced when working on issue 124638.

Has someone got a build immediately before r1599233?
Comment 7 slacka 2014-10-03 10:40:20 UTC
$ svnversion -> 1599230M is good
r1599230 is good
r1599676 is bad

r1599676 | alg | 2014-06-03 12:43:56 -0400 (Tue, 03 Jun 2014) | 1 line

i124638 Corrected paints of Writer Frames with DrawingLayer FillAttributes for all systems and AA/nonAA

Armin, you worked on AA work during this period and turning off AA fixes the issue. Could you please investigate this further?
Comment 8 Armin Le Grand 2014-10-06 14:02:33 UTC
@mroe, comment 5: Just tried PDF with some colored paragraphs, I see no 'lines' in the PDF when viewed.
Also tried printing (with some pseudo pre-priinter), it's the same - no 'lines' there.
The problem is that with multiple paragraphs when the fill is painted AAed the 'edges' of AAed areas do not well 'add' to closed color planes. I still see no evidence that this is (in this sense) not a visualisation problem in edit view. It should still be improved in edit view, though.
Comment 9 Armin Le Grand 2014-10-07 16:07:52 UTC
Finetuning as much as possible...
Comment 10 Armin Le Grand 2014-10-07 16:11:54 UTC
In a ideal world Writer would create high-res coordinates, but currently it crunches them in integer (must not be a bad thing btw) and also 'bends' them under some circumstances to get overlapping lines non-overlapping (future idea: visualize this using AAed lines with transparency -> overlapping edit-only lines can be eye-detected smoothly without that hassle).
The new fill stuff is in double precision (primitives) but originates from that integer stuff, thus currently some adaption has to take place. Additionally the common problem with non-additive AAed edges comes into play (opacity of 0.5 mixed with opacity 0.5 gives opacity 0.75, not full opacity)...
Comment 11 Armin Le Grand 2014-10-07 16:18:25 UTC
Finetuned, checked edit view, preview, print (dialog and real), pdf export, looks good. Preparing commit...
Comment 12 SVN Robot 2014-10-07 16:21:00 UTC
"alg" committed SVN revision 1629919 into trunk:
i125698 Finetuned visualization for aligned AAed areas
Comment 13 Armin Le Grand 2014-10-07 16:31:59 UTC
Okay, done.