Issue 125988 - Text for dropdown box within view dialog too long
Summary: Text for dropdown box within view dialog too long
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-01 13:45 UTC by Thorsten Wagner
Modified: 2015-01-07 23:13 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch (3.70 KB, patch)
2015-01-01 13:45 UTC, Thorsten Wagner
rb.henschel: review-
Details | Diff
Screenshot without patch (315.22 KB, image/jpeg)
2015-01-01 13:46 UTC, Thorsten Wagner
no flags Details
Screenshot with patch (279.31 KB, image/jpeg)
2015-01-01 13:46 UTC, Thorsten Wagner
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Thorsten Wagner 2015-01-01 13:45:35 UTC
Created attachment 84341 [details]
Patch

The text "Automatic (Galaxy (default))" for the style dropdown box within preferences / OpenOffice / view dialog is too long.

I supplied a patch attached to this bug report.

The current dialog is shown in "Screenshot without patch.png" attached to this bug report. The affected dropdown box is marked with a red box.

With patch applied the result is shown in "Screenshot with patch.png". The affected dropdown box is marked with a red box again.

In addition I adjusted the check box text label "Screen font antialiasing". The position of the remaining dialog elements on the dialog's left side are adjusted too.

I'm able to test on Mac OS X only. The patch has to be retested on Mac OS X, but it has to be tested on Windows and Linux too.
Comment 1 Thorsten Wagner 2015-01-01 13:46:06 UTC
Created attachment 84342 [details]
Screenshot without patch
Comment 2 Thorsten Wagner 2015-01-01 13:46:32 UTC
Created attachment 84343 [details]
Screenshot with patch
Comment 3 Regina Henschel 2015-01-02 13:31:05 UTC
Comment on attachment 84341 [details]
Patch

The patch removes the title case of the headings in the dialog. I think, that those headings should remain in title case.
Comment 4 Thorsten Wagner 2015-01-02 13:45:18 UTC
(In reply to Regina Henschel from comment #3)
> Comment on attachment 84341 [details]
> Patch
> 
> The patch removes the title case of the headings in the dialog. I think,
> that those headings should remain in title case.

I don't know what exactly is removed here from you point of view. It would be very nice to have a screenshot attached for better understanding.
Comment 5 Regina Henschel 2015-01-02 14:07:27 UTC
Your patch does
User Interface --> User interface
Font Lists --> Font lists

I have noticed, that the headings in that dialog are inconsistent formated. Solution would be to change
Graphics output --> Graphics Output

A new issue about this inconsistency should be generated with a separate patch for only that problem. Having patches for single problems makes it easier to find the connection between code change and problem in the history of the code.


An additional problem is, that your patch removes the line wrap in the text
"Use system font for user interface"
But that line wrap is needed for some languages. For example in German the text is
"Systemschriftart für die Benutzeroberfläche verwenden"
That is much longer than the English text and would not fit without line break.
Comment 6 Thorsten Wagner 2015-01-02 19:39:40 UTC
I don't see any inconsistency. Only the first word is using capital letters at the beginning. This is consistent to the other preference dialogs. But there are other dialog boxes, e.g. hyperlink tab in Writer's character formatting dialog, which are using capital letters at the beginning of all words. The right formatting has to be defined. Currently most of the dialogs are using only a single capital letter at the beginning.

Reason of removing line wrap was a shift of the text slight up with OS X. This shift is caused by the line wrap. I'll try to find a better solution preserving line wrap.
Comment 7 Regina Henschel 2015-01-07 23:13:32 UTC
You are right about the capital letters, not all but most headings do not use title case. That is different to LibreOffice. So your change is acceptable.

The problem with the line wrap remains.